Prefix form-required classes with js-

I manually tested this patch, and I can't really figure out how this is used in Javascript. I can see the js-form-required class added but all Javascript seems to do is add/remove the form-required class for styling. It doesn't seem to use it for functionality.

Can @nod_ confirm?

Save us nod!

@lewis: indeed. I can't see form-required used for JS functionality.

The form-required is hardcoded in the states.js file though, that's ok with you? I see it's removed from the default datetime wrapper thing, just asking.

Ok, thanks for clarifying that. I'm ok with this patch, we can always improve this separation down the road, this is not a good time to get our hands dirty in states.js :)

works as expected also in stark
and yes we can fix & pretty up more further down the road.

reroll

rerolled

This needed rerolling.

Thanks. I manually tested this patch and the JS still kicks in.

+++ b/core/includes/theme.inc
@@ -1581,6 +1581,7 @@ function template_preprocess_field_multiple_value_form(&$variables) {
+      $header_attributes['class'][] = 'js-form-required';
       $header_attributes['class'][] = 'form-required';

+++ b/core/modules/system/templates/datetime-wrapper.html.twig
@@ -17,7 +17,7 @@
-    required ? 'form-required',
+    required ? 'js-form-required',

+++ b/core/modules/system/templates/fieldset.html.twig
@@ -33,7 +33,7 @@
-      required ? 'form-required',
+      required ? 'js-form-required',

+++ b/core/modules/system/templates/form-element-label.html.twig
@@ -18,7 +18,7 @@
-    required ? 'form-required',
+    required ? 'js-form-required',

This seems inconsistent - we're adding both classes in the form API but we're not in the default templates - how come?

@Cottser yes but those issue completely removed the class they were changing from core - this issue (and the other) has not managed to do that. Therefore the current patch leaves core very inconsistent wrt to whether the form-required class is there.

Needs work based on the consensus in #2431671: [meta] Add in js- prefixed classes for separation of JS & CSS functionality

I have added the form-required class back to 3 twig templates :)

Simple! Thanks.

Committed 01e703d and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.