Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Task
Prefix text-* classes with js- to separate classes needed for JavaScript functionality from those used for styling and make it clear which classes can safely be removed without breaking JavaScript functionality.
Affected classes:
- text-format-wrapper
- text-full
- text-summary
- text-summary-wrapper
Remaining tasks
- Patch
- Patch review
- Manual testing
Steps to test
- Navigate to
node/add/article
- Click on the "Edit Summary" link
- Click on the "Hide Summary" link
Beta phase evaluation
Issue category | Task |
---|---|
Issue priority | Normal |
Unfrozen changes | Unfrozen because it mostly just affects templates and JS which are not frozen. |
Prioritized changes | The main goal of this issue is to improve themer experience and arguably it reduces fragility where JavaScript and markup intersect. |
Disruption | Shouldn't be too disruptive as it is mostly affecting CSS classes that are added to markup. Themes extending Classy will only have classes added. Themes not extending Classy will have classes removed but they can be added back via template overrides. |
User interface changes
None for themes extending Classy. Possible visual changes for other themes.
API changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#4 | 2473957-text-forms-split-4.patch | 4.77 KB | sqndr |
#4 | interdiff.txt | 421 bytes | sqndr |
#1 | 2473957-text-forms-split.patch | 4.49 KB | star-szr |
Comments
Comment #1
star-szrPatch split from parent issue. I wasn't able to find anything additional by grepping.
Comment #2
LewisNyman CreditAttribution: LewisNyman at Wunder commentedI grepped and I found one more find function in
text.js
:Comment #3
star-szrExcellent, thanks Lewis!
Comment #4
sqndr CreditAttribution: sqndr commentedI went on and wrote a patch for that. Tested on
node/add/article
and "Edit Summary" & "Hide Summary" still works.Comment #5
sqndr CreditAttribution: sqndr commentedComment #6
sqndr CreditAttribution: sqndr commentedComment #7
LewisNyman CreditAttribution: LewisNyman at Wunder commentedAce, I manually tested this patch and it stills works. Thanks!
Comment #8
Manjit.Singhworking fine for me :)
Comment #9
alexpottThis is actually fixing a bug since...
... the default filter template had had the classes removed.
Committed d4bef05 and pushed to 8.0.x. Thanks!
Comment #11
star-szrWoo! Thanks all :)