Variable to config: menu.settings [d7]

Attached is the YAML for this issue, from the patch in #2382117: Migration Files for Drupal 7 Variables.
Test(s) (and maybe a dump file) still need to be written.

Added organization support to Anexus IT

Will need to be submitted again to Core since moving from sandbox.

Updated, with a test.

Looks fine to me, just a missing comment on testMigration if someone wants to fix that.

The migrate needs to move to a template - see #2463909: Migrations should support non-installed default configurations (templates) and I think the test group is wrong see #2495271: Split the migrate_drupal test suite in to 6.x and 7.x groups

Re-rolled.

Changed test group.

Re-rolling. I can't create an interdiff because of conflicts between the two patches (due to the unmergeability of the {variable} table dump).

Re-rolled again. No interdiff for the same reason I mentioned in #15.

And yet again.

EDIT: Um. Clicked Save on an empty comment. That was durmb.

Here's a diff between the D6 and D7 menu_settings migrations.

1. +++ b/core/modules/menu_ui/migration_templates/d7_menu_settings.yml
   @@ -1,16 +1,12 @@
   -    - menu_primary_links_source
   -    - menu_secondary_links_source
   

   I assume these variables existed in D6 but not D7?

2. +++ b/core/modules/menu_ui/src/Tests/Migrate/d7/MigrateMenuSettingsTest.php
   @@ -2,46 +2,34 @@
   + * Contains \Drupal\menu_ui\Tests\d7\Migrate\MigrateMenuSettingsTest.
   

   Migrate <=> d7

3. +++ b/core/modules/menu_ui/src/Tests/Migrate/d7/MigrateMenuSettingsTest.php
   @@ -2,46 +2,34 @@
   -class MigrateMenuConfigsTest extends MigrateDrupal6TestBase {
   +class MigrateMenuSettingsTest extends MigrateDrupal7TestBase {
   

   Why the different class name?

4. +++ b/core/modules/menu_ui/src/Tests/Migrate/d7/MigrateMenuSettingsTest.php
   @@ -2,46 +2,34 @@
   +    $this->installConfig(['menu_ui']);
   

   Why is this necessary for D7 but not D6?

5. +++ b/core/modules/menu_ui/src/Tests/Migrate/d7/MigrateMenuSettingsTest.php
   @@ -2,46 +2,34 @@
   -  public function testMenuSettings() {
   -    $config = $this->config('menu_ui.settings');
   -    $this->assertIdentical(FALSE, $config->get('override_parent_selector'));
   -    $this->assertConfigSchema(\Drupal::service('config.typed'), 'menu_ui.settings', $config->get());
   +  public function testMigration() {
   +    $this->assertTrue(\Drupal::config('menu_ui.settings')->get('override_parent_selector'));
   

   Why the test function name change (testMenuSettings -> testMigration)?

   The D6 test is looking for a FALSE value, but the D7 test is looking for a TRUE value?

The menu_primary_links_source and menu_secondary_links_source variables existed in both D6 and D7. However, they have no counterpart in D8. The D6 migration was mistaken. Once I removed those variables from the D6 migration, though, I realized that the d6_menu_settings and d7_menu_settings migrations were identical. So this patch condenses them into a single migration tagged for both Drupal 6 and Drupal 7.

1. Removed, as explained above.
2. Fixed -- there's now only one test, in Drupal\menu_ui\Tests\Migrate.
3. Because it follows the name of the destination config object. This is consistent with what the System module's several variable-to-config migrations do, and I'm in favor of adopting that pattern going forward.
4. I don't know, but it seems like the smart thing to do. Before migrating configuration, the destination config object should be made available, no?
5. The D6 and D7 migrations were looking for different values because of the content of the {variable} table dump. It now looks only for TRUE, and the one test is based on the Drupal 7 dump data. The name of the method changed for no particular reason; I had probably originally copy-and-pasted the test from another place (not related to menu_ui), and changed the method name as a matter of course.

discussed with phenaproxima and he added those two to the known issues. if there's nothing to migrate them to, well.

Hm, right. Those are just straight-up blocks now. Yay for less one-off crap!

Committed and pushed to 8.0.x. Thanks!

@webchick I dont if is possible to amend the attribution in this commit, because the original patch created by @miguelc303 and myself but splited by @oadaeh from issue #2382117: Migration Files for Drupal 7 Variables