Problem/Motivation

See parent issue.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#12 interdiff.txt520 bytestim.plunkett
#12 2325485-field_ui-13.patch1.2 KBtim.plunkett
#11 2325485-field_ui-11.patch1.13 KBtim.plunkett
#5 convert-2325485-5.patch1.29 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Issue tags: +hook_element_info
swentel’s picture

swentel CreditAttribution: swentel commented
Related issues: +#1898068: field_ui.module - Convert theme_ functions to Twig

We should probably get #1898068: field_ui.module - Convert theme_ functions to Twig done first.

swentel’s picture

swentel CreditAttribution: swentel commented
Related issues: -#1898068: field_ui.module - Convert theme_ functions to Twig

Ok, ignore my comment.

almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Issue tags: +Novice
almaudoh’s picture

almaudoh CreditAttribution: almaudoh commented
Status: Active » Needs review
FileSize
convert-2325485-5.patch1.29 KB

Status: Needs review » Needs work

The last submitted patch, 5: convert-2325485-5.patch, failed testing.

Status: Needs work » Needs review

swentel queued 5: convert-2325485-5.patch for re-testing.

swentel’s picture

swentel CreditAttribution: swentel commented

Ok, we'll have to wait until #2327965: drupal_flush_all_caches() doesn't clear all plugin caches gets in.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Nope, even that won't fix it. Like all of the other issues, we're blocked on #2326409: Annotate render element plugins and have NO solution yet.

Status: Needs review » Needs work

The last submitted patch, 5: convert-2325485-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
2325485-field_ui-11.patch1.13 KB

Rerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
2325485-field_ui-13.patch1.2 KB
interdiff.txt520 bytes

The last submitted patch, 11: 2325485-field_ui-11.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

This is simple enough patch so RTBC.

+++ b/core/modules/field_ui/src/Element/FieldUiTable.php
@@ -0,0 +1,30 @@
+ *   RenderElement("field_ui_table")

Lol I didn't know about that :D

  • webchick committed c1c7e14 on 8.0.x 
    Issue #2325485 by tim.plunkett, almaudoh: Convert field_ui_element_info...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.