field_ui.module - Convert theme_ functions to Twig [#1898068]

Task

Use Twig instead of PHPTemplate

Twig sandbox: http://drupal.org/sandbox/pixelmord/1750250

Remaining

* replace all tpl.php files with .html.twig equivalents
* replace all theme functions with .html.twig equivalent templates
* add new preprocess functions for the .html.twig equivalent templates
* update all hook_theme definitions

We should add 'file' => 'field_ui.admin.inc' to the hook_theme() definition:

/**
 * Implements hook_theme().
 */
function field_ui_theme() {
  return array(
    'field_ui_table' => array(
      'render element' => 'elements',
      'file' => 'field_ui.admin.inc',
      'template' => 'field-ui-table',
    ),
  );
}

Theme function name/template path	Conversion status
theme_field_ui_table	Needs to be brought over from the sandbox.

#1757550: [Meta] Convert core theme functions to Twig templates

Comment	File	Size	Author
#9	twig-field-ui-1898068-9.patch	3.23 KB	shanethehat
#9

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

c4rl CreditAttribution: c4rl commented 25 January 2013 at 06:06

Issue tags:

+Twig

Tagging

Comment #2

duellj CreditAttribution: duellj commented 12 February 2013 at 21:22

Given #1876712: [meta] Convert all tables in core to new #type 'table', this issue should be closed, since there's no other theme functions in field_ui outside of the table theme.

Comment #3

c4rl CreditAttribution: c4rl commented 12 February 2013 at 21:45

Let's wait until #1876712: [meta] Convert all tables in core to new #type 'table' is marked fixed before deciding whether we should close this one.

Comment #4

joelpittet

English

Vancouver

CreditAttribution: joelpittet commented 22 March 2013 at 03:07

Status:

Active

» Postponed

Just an update: here is the issue for this conversion.
#1938900: Convert theme_field_ui_table into a template

I had a look at that conversion and it looks quite involved, they have their own pre_render that may not gel with #type=>table's prerender and it's being used in a few spots.

Marking as postponed to see if we can push a bit more help getting those #type=>table conversions out of the way.

Comment #5

star-szr

he/him

English

CreditAttribution: star-szr commented 12 April 2013 at 14:19

Status:

Postponed

» Active

Since #1938900: Convert theme_field_ui_table into a template is not a form table, I think we need to do a Twig conversion for now.

Tagging as a Novice task to bring over this conversion from the sandbox.

I recommend taking a look at @c4rl's screencast: http://www.youtube.com/watch?v=HS4yKJjrb2E

If you'd like to work on this, please assign the issue to yourself. If you get stuck, drop by #drupal-twig on IRC or post your questions here. Thanks!

Comment #6

swentel CreditAttribution: swentel commented 12 April 2013 at 14:22

Issue tags:

+Field API

Tagging

Comment #7

star-szr

he/him

English

CreditAttribution: star-szr commented 12 April 2013 at 14:31

Issue tags:

+Novice

Thanks @swentel, I should have brought that over. And I forgot to actually add the Novice tag.

Comment #8

shanethehat CreditAttribution: shanethehat commented 12 April 2013 at 14:48

Assigned:

Unassigned

» shanethehat

Comment #9

shanethehat CreditAttribution: shanethehat commented 12 April 2013 at 15:48

Status:

Active

» Needs review

File	Size
twig-field-ui-1898068-9.patch	3.23 KB

I have a question about

function template_preprocess_field_ui_table(&$variables) {
  $elements = $variables['elements'];
  $table = array();
  $js_settings = array();

The $js_settings variable does not seem to be used, and Netbeans wants me to delete it!

Comment #10

shanethehat CreditAttribution: shanethehat commented 12 April 2013 at 15:53

Assigned:

shanethehat

» Unassigned

Comment #11

12 April 2013 at 16:50

Status:

Needs review

» Needs work

The last submitted patch, twig-field-ui-1898068-9.patch, failed testing.

Comment #12

shanethehat CreditAttribution: shanethehat commented 12 April 2013 at 17:04

Assigned:

Unassigned

» shanethehat

Oops.

Comment #13

star-szr

he/him

English

CreditAttribution: star-szr commented 12 April 2013 at 17:45

Assigned:	shanethehat	» Unassigned
Status:	Needs work	» Closed (won't fix)
Issue tags:	-Novice, -Field API

I'm terribly sorry @shanethehat, I should have confirmed this first but I spoke with @duellj and it sounds like this would work better as a #type table conversion after all. Hope it was good practice for you at least.

Comment #14

c4rl CreditAttribution: c4rl commented 6 May 2013 at 21:52

Title:

Convert field_ui module to Twig

» field_ui.module - Convert theme_ functions to Twig

Per #1757550-44: [Meta] Convert core theme functions to Twig templates, retitling to indicate this issue applies to theme_ functions, which are lower in priority than PHPTemplate conversion issues.