Convert type selectors to be compatible with jQuery native-API selector

Good start, thanks!

The :input selector needs to be removed as well.

- can we don't drop the quotation mark ?

+++ b/core/misc/ajax.js
@@ -200,7 +200,7 @@ Drupal.ajax = function (base, element, element_settings) {
+      if (this.form.find('[type=file]').length) {

find('[type="file"]')

- add back input / button when it's possible ?

input[type="file"]

for :input it shouldn't be find('*') but find('input,button,textarea,select'), :input should disapear from everywhere.

Looking at the sizzle source the replacements should be:

• for :radio, :checkbox, :file, :password, :image replaced with input[type=XXX]
• for :submit, :reset replaced with input[type=XXX], button[type=XXX]
• for :input replaced with .filter('input,select,textarea,button')

Let's be explicit about the replacements and not just select things without tag name.

The content_translation file is borked, needs works.
The formEditor file should just send the string as the filter for the event delegation, no need to select all the elements. Also there is a bug, you're using a variable that you defined in another scope. Run JSHint before you send the patch :)
In tableresponsive, why do you select the parent() element for the headers? That shouldn't be needed.

Getting there :)

dropped the changes in form.js, it'll get rewritten in another issue. And the extra semicolon. While it's a valid fix it's out of scope.
The changes in tableresponsive will not work like that. Let's leave it for another issue.

See interdiff. You're removing pieces of a selector that should be needed, it'd be even better if you try to test the changes you make so you can catch syntax error and things that don't work properly.

Re-rolled

Tested changes and following coding standards.

you can't RTBC a patch you worked on :)

The re-rolled was quite simple and direct, but I'm fine with it :)

True, it would have been fine if it was RTBC previously. The ways of the core queue :p

1. +++ b/core/misc/vertical-tabs.js
   @@ -102,7 +102,7 @@ Drupal.verticalTab = function (settings) {
   +      $('.vertical-tabs-pane').find('input,button,textarea,select').filter(':visible:enabled').first().trigger('focus');
   

   add space after comma: input, button, textarea, select

2. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@ Drupal.behaviors.contentTranslation = {
   -    .on('click', 'table .field-settings .translatable :input', function (e) {
   +    .on('click', 'input', function (e) {
   

   Please explain why it dropped the selectors.

3. +++ b/core/modules/edit/js/editors/formEditor.js
   @@ -107,9 +107,9 @@ Drupal.edit.editors.form = Drupal.edit.EditorView.extend({
   -
   +      ¶
   

   space problem

4. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@ Drupal.behaviors.contentTranslation = {
   +    $('body').once('translation-entity-admin-bind').on('click',  'table .bundle-settings .translatable input', function (e) {
   

   space problem

5. +++ b/core/modules/views_ui/js/views-admin.js
   @@ -177,7 +177,7 @@ Drupal.behaviors.addItemForm = {
   +  this.$form.find('.views-filterable-options input[type=checkbox]').on('click', $.proxy(this.handleCheck, this));
   

   input[type="checkbox"]. don't drop the quote marks.

When re-rolling you should know that the indentation standard changed for JavaScript files.

Re-rolled patch from #14.
Applied suggestions 1-5 from #21.

About why it dropped the selectors:

+++ b/core/modules/content_translation/content_translation.admin.js
@@ -70,35 +70,35 @@ Drupal.behaviors.contentTranslation = {
- .on('click', 'table .field-settings .translatable :input', function (e) {
+ .on('click', 'input', function (e) {
Please explain .

Seems it was decided in #13.

#24

Added spaces between selectors.

Patch applies well and nothing seems to be broken. Should I test anything else or is it a RTBC?

1. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@
   -      $('body').once('translation-entity-admin-bind').on('click', 'table .bundle-settings .translatable :input', function (e) {
   +      $('body').once('translation-entity-admin-bind').on('click', 'table .bundle-settings .translatable input', function (e) {
   ...
   -          $bundleSettings.find('.operations :input[name$="[language_show]"]').prop('checked', true);
   -          $fieldSettings.find('.translatable :input').prop('checked', true);
   +          $bundleSettings.find('.operations input').filter('input[name$="[language_show]"]').prop('checked', true);
   +          $fieldSettings.find('.translatable input').prop('checked', true);
   ...
   -        .on('click', 'table .field-settings .translatable :input', function (e) {
   +        .on('click', 'input', function (e) {
   

   jQuery :input = input, button, textarea, select

   any reason it dropped the "select" & "textarea" elements?

2. +++ b/core/modules/edit/js/editors/formEditor.js
   @@ -110,7 +110,7 @@
   +          .on('formUpdated.edit', 'input,button,textarea,select', function (event) {
   
   @@ -147,7 +147,7 @@
   +        .off('change.edit', 'input,button,textarea,select')
   

   add space after comma, please :)

3. +++ b/core/misc/vertical-tabs.js
   @@ -102,7 +102,7 @@
   +        $('.vertical-tabs-pane').find('input, button, textarea, select').filter(':visible:enabled').first().trigger('focus');
   

   .first() -> eq(0)

About 1) I think it was only 'input' there, because there are no other elements.
If you think we still need all these selectors - 'input, button, textarea, select' I have added in this patch.
Also 2) and 3) fixed.

Rerolled.

Re-rolled!

Rerolled patch

1. +++ b/core/misc/vertical-tabs.js
   @@ -102,7 +102,7 @@
   +        $('.vertical-tabs-pane').find('input, button, textarea, select').filter(':visible:enabled').eq(0).trigger('focus');
   

   Are you sure about that CSS class change? wouldn't want to break stuff :)

2. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@
   +      $(context).find('table .bundle-settings .translatable').find('input, button, textarea, select').once('translation-entity-admin-hide', function () {
   

   Shouldn't be possible to use .once like that. Needs to be replaced with .once('translation-entity-admin-hide').each(function () {…

3. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@
   +      $('body').once('translation-entity-admin-bind').on('click', 'table .bundle-settings .translatable input, button, textarea, select', function (e) {
   

   Let's not change that one, the selector is not working like you'd expect. Like that it listen to click on all buttons, textarea and select of the page.

4. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@
   +          $bundleSettings.find('.operations input').filter('input[name$="[language_show]"], button, textarea, select').prop('checked', true);
   

   Similar thing going on here, let's not change it yet.

5. +++ b/core/modules/content_translation/content_translation.admin.js
   @@ -70,35 +70,35 @@
   +        .on('click', 'input, button, textarea, select', function (e) {
   

   Same here.

6. +++ b/core/modules/quickedit/js/editors/formEditor.js
   @@ -111,7 +111,7 @@
   +          .on('formUpdated.quickedit', 'input,button,textarea,select', function (event) {
   

   Just needs some spaces after , but fine otherwise.

7. +++ b/core/modules/quickedit/js/views/EditorView.js
   @@ -184,7 +184,7 @@
   +        $form.find('input[type!="hidden"][type!="submit"],textarea')
   

   This one looks wrong, let's not change it.

Convert type selectors, changes from comment #41

Applied changes from comment #41.

Added minor change from comment #45.

the patch produces merge conflict in ajax.js - due to outdated patch.
FYI working on it at BarcelonaCon 2015 extended sprint.

the straight re-rolled patch.
merge conflict in ajax.js has been removed during development of the master, no need for to fix something in there.

cleaned the code up. now it is a bit more readable.

+++ b/core/modules/views_ui/js/views-admin.js
@@ -268,11 +268,13 @@
+    ¶

there is a tab in the patch

@hass: thanks, I have missed that.
no interdiff, coz empty space replaced by empty space...

+++ b/core/misc/vertical-tabs.js
@@ -124,7 +124,12 @@
+        $('.vertical-tabs__pane')
+          .find('input, button, textarea, select')
+          .filter(':visible:enabled')
+          .eq(0)
+          .trigger('focus');
+        $('.vertical-tabs__pane').find('input, button, textarea, select').filter(':visible:enabled').eq(0).trigger('focus');

This looks like the same twice.

Removed the redundant line as per #53.

@er.pushpinderrana sorry, had this duplicated line inside. But we need to remove the later, not the more explicit and readable one, please. Patch atteched

Thanks ALL for your hard-working! Let's do it when we have more JS test cases covered.

Promoting to major alongside the parent.

I added the Portland2022 tag. I also added the Needs issue summary update tag to clarify what the next steps are based on the recent issue fork from @bnjmnm several months ago.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

I have re-rolled the patch for 10.1.x please review

Cleaning up the tags.

Searched fore each of the patterns manually in core and appears reroll got them.

Downgrading to normal though as if this was major like to think it would of been addressed.