modules/system/system.install:1728: update_variables_to_config('system.authorize'

Thanks in advance for helping many hands to make light work!
See #2181257: [meta] Variables to config migration [d7] for instructions

CommentFileSizeAuthor
#22 2130577-22.patch8.34 KBphenaproxima
#19 2130577-19.patch8.4 KBphenaproxima
#18 2130577-18.patch8.49 KBphenaproxima
#15 2130577-15.patch8.33 KBphenaproxima
#14 2130577-14.patch239.81 KBphenaproxima
#10 imp-v2c-system-authorize-2130577-10.patch3.35 KBsamhassell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fastangel’s picture

fastangel CreditAttribution: fastangel commented
Assigned: Unassigned » fastangel

working on this.

fastangel’s picture

fastangel CreditAttribution: fastangel commented
Status: Active » Needs review

I can't find a variable to map with D6. The unique variable that exist in d8 is filetransfer_default.

chx’s picture

chx CreditAttribution: chx commented
Title: Variable to config: system.authorize » Variable to config: system.authorize [D7]
Status: Needs review » Postponed

The whole authorization system is a D7 invention.

eliza411’s picture

eliza411 CreditAttribution: eliza411 commented
Project: IMP » Drupal core
Version: » 8.x-dev
Component: Code » migration system
Assigned: fastangel » Unassigned

Moving to the core queue to consolidate issues now that we're doing all the work there.

eliza411’s picture

eliza411 CreditAttribution: eliza411 commented
Title: Variable to config: system.authorize [D7] » Variable to config: system.authorize [d7]
Issue summary: View changes
eliza411’s picture

eliza411 CreditAttribution: eliza411 commented
Status: Postponed » Active
Parent issue: #2125745: [meta] Variables to config migration [D6] » #2181257: [meta] Variables to config migration [d7]
eliza411’s picture

eliza411 CreditAttribution: eliza411 commented
Project: Drupal core » IMP
Version: 8.x-dev »
Component: migration system » Code
samhassell’s picture

samhassell CreditAttribution: samhassell commented
Assigned: Unassigned » samhassell
samhassell’s picture

samhassell CreditAttribution: samhassell commented

filetransfer_default is the only config item listed in system.authorize.yml. It doesn't have a default listed - its NULL by default.

Over in [6598728] I can see that the filetransfer_default variable was renamed from authorize_filetransfer_default during its cmi conversion, so this needs to be reflected in the patch.

The default value for filetransfer_default in D7 and D8 is NULL. Other values are provided by hook_filetransfer_info(), such as system_filetransfer_info() providing 'ssh' and 'ftp'. It would be good to have the tests working using either ssh or ftp, but I can't get that working at the moment.

samhassell’s picture

samhassell CreditAttribution: samhassell commented
Status: Active » Needs review
FileSize
imp-v2c-system-authorize-2130577-10.patch3.35 KB

patch attached. I've kept the names of the patch the same as the name of the destination file 'system.authorize.yml'. So theres not much mention of 'config' or 'settings'. Can reroll if it should be renamed.

Test is passing. It uses 'ssh'.

benjy’s picture

benjy CreditAttribution: benjy commented
Assigned: samhassell » Unassigned
Status: Needs review » Fixed

Thank you! Committed: 773b241

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jcost’s picture

jcost CreditAttribution: jcost commented
Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system
Status: Closed (fixed) » Needs work

Will need to be submitted again to Core since moving from sandbox.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Status: Needs work » Needs review
FileSize
2130577-14.patch239.81 KB

Rerolled against 8.0.x, with a test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
FileSize
2130577-15.patch8.33 KB

Whoops -- maybe don't include all the modifications to the dump files this time!

The last submitted patch, 14: 2130577-14.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 15: 2130577-15.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Status: Needs work » Needs review
FileSize
2130577-18.patch8.49 KB

Let's try that again.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
FileSize
2130577-19.patch8.4 KB

Minor test cleanup.

Status: Needs review » Needs work

The last submitted patch, 19: 2130577-19.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs work » Postponed

Blocked by #2495755: Create MigrateDrupal7TestBase.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review
FileSize
2130577-22.patch8.34 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Parent issue: #2181257: [meta] Variables to config migration [d7] » #2500533: Upgrade path for System 7.x

Needs to be merged into the parent issue.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Closed (won't fix)

Merged into the parent issue.