Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The current option summary for 'Link display' in the DisplayPluginBase class is unclear and can lead to confusion. This issue aims to improve clarity by updating the option summary text to 'Destination.'
I would suggest to use the word "Destination" to replace "Link display".
The settings box for this option displays a title
'Which display to use for path' and help text
'Which display to use to get this display's path for things like summary links, rss feed links, more links, etc.'
These seem hard to understand. Should we change that?
Steps to reproduce
* Navigate to a Views view with a Block display
* On the Block display, observe the 'Link display' option in the pager category.
Proposed resolution
Update the title of the 'link_display' option from:
'title' => $this->t('Link display'),
to:
'title' => $this->t('Destination'),
This change provides a more descriptive and understandable label for the option.
User interface changes
Before
After
Now, double click on the 'Link Display' option, a pop-up settings box appears with title
'Which display to use for path' and help text
'Which display to use to get this display's path for things like summary links, rss feed links, more links, etc.'
Test plan
* Navigate to a Views configuration page.
* Verify that the 'Link display' text in the option summary is now replaced with 'Destination.'
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | Text After patch.png | 82.72 KB | sandeep_k |
| #20 | Text Before patch.png | 109.51 KB | sandeep_k |
| Screen Shot 2013-09-12 at 1.36.26 AM.png | 16.52 KB | jiv_e | |
| Screen Shot 2013-09-12 at 1.34.11 AM.png | 28.33 KB | jiv_e | |
| Screen Shot 2013-09-12 at 1.30.37 AM.png | 16.71 KB | jiv_e |
Issue fork drupal-2087139
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #1
dawehnerCould we not just add a new group, as the link display really simply not belongs to the pager.
Comment #14
smustgrave commentedSlightly reviewing very old tickets as part of needs-review-queue-initiative
This still appears to be the case and agree "Link display" is slightly off.
Comment #15
smustgrave commentedProbably a good task for new users.
Comment #18
drupaler_kushal commentedCompleted the text change as suggested. Please review the PR https://git.drupalcode.org/project/drupal/-/merge_requests/6282.
Comment #19
sandeep_k commentedHi @Drupaler_Kushal, I've Tested the shared MR- MR !6282 mergeable on the Drupal- 11.0-dev version, The Patch was applied successfully and looks good to me.
Testing Steps:
Testing Results:
After applying the patch, the text label is changed now. RTBC++
Comment #20
sandeep_k commentedAttaching Test results here
Comment #21
smustgrave commentedWas tagged for issue summary and tests.
Comment #22
pooja saraah commentedIssue Summary:
Problem/Motivation:
The current option summary for 'Link display' in the DisplayPluginBase class is unclear and can lead to confusion. This issue aims to improve clarity by updating the option summary text to 'Destination.'
Steps to Reproduce:
* Navigate to a Views configuration page.
* Observe the 'Link display' option in the pager category.
Proposed Solution:
Update the title of the 'link_display' option from:
'title' => $this->t('Link display'),
to:
'title' => $this->t('Destination'),
This change provides a more descriptive and understandable label for the option.
Test Plan:
* Before applying the patch:
* Verify that the option summary for 'Link display' is present on a Views configuration page.
* Confirm that the text is currently set to 'Link display.'
* Apply the Patch:
* Apply the provided patch to update the 'Link display' text to 'Destination.'
* Confirm that the patch applies cleanly without conflicts.
* After applying the patch:
* Navigate to a Views configuration page.
* Verify that the 'Link display' text in the option summary is now replaced with 'Destination.'
Comment #23
smustgrave commentedIssue summaries shouldn’t go in a comment. And full template should be used.
Test could be as simple as an assertion somewhere
Comment #24
pooja saraah commentedComment #25
pooja saraah commentedComment #26
smustgrave commentedPlease read the comments and tags. This was tagged for a simple test which isn’t done.
Comment #27
drupaler_kushal commentedWhat is pending now in this?
Comment #29
sumit-k commentedI've added a simple functional test to validate the changes made to the label.
Comment #30
lendudePlease search the Views and Views UI modules (and maybe others?) for 'Link display' and update all occurrences everywhere. Please make sure the changed sentences still make sense, not sure a find/replace is going to work everywhere
Did anybody ever look into moving this out of the pager section? I agree with @dawehner in #1 that this feel like a weird place for this.
Do we need to think about updating the machine name of the setting too? We now have a big difference between the name of the field in code and the name in the UI which can lead to more confusion but now from a DX perspective
Do we need to run the new label past some UI experts and make sure we all agree this is the best we can come up with, 'Destination' feels a bit vague to me.
Comment #31
johnvITMT, on D11.1, I cannot find the 'Link display' option in the pager setting, or anywhere on the view settings page, whereas #19 states it is still there on D11.0.
(EDIT: That is on a Page display - when checking a Block display, I can see the option. --> Updating summary with test
As suggested in #30, indeed, the term 'Link display' is still used elsewhere, amongst other in the 'more' link setting. These still must be addressed.
As dawehner suggests in #1 "Could we not just add a new group, as the link display really simply not belongs to the pager", the setting may move to a better location (affecting only the UI, not the saved configuration setting itself)
Now is the time!