Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 20:03 UTC
Updated:
29 Jul 2014 at 22:24 UTC
Jump to comment: Most recent file
Comments
Comment #1
daven commentedI think I got this one.
Comment #2
daven commentedComment #3
daven commentedComment #4
elijah lynnApplies fine and no errors after patching with mild testing.
Comment #6
daven commented#2: drupal-rename-views-methods-2003544-2.patch queued for re-testing.
Comment #7
aspilicious commentedShould be "public function addNotEndsWith()"
Comment #8
daven commentedAttaching new patch with scope modifiers according to Drupal standards.
I now see in the parent issue it's noted that we should be adding the scope on these too: http://drupal.org/node/1856630#comment-6806902
Comment #9
heddnIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opNotEndsWith.
Comment #10
daven commentedCommand line patching...
Comment #11
daven commentedforgot to set status.
Comment #12
aspilicious commentedTalkes with dawehner about this, should be protected. Srry!
Comment #13
daven commentedComment #14
somepal commentedreviewed drupal-rename-views-methods-2003544-13.patch. gtg.
Comment #15
alexpottNeeds a reroll
Comment #16
daven commentedComment #17
daven commentedIn case I need to do this again:
Comment #18
daven commentedmoving target. this one doesn't apply either. looks like it's been renamed elsewhere.
Comment #19
daven commentedJust found https://drupal.org/node/2003540 which means it looks like this issue is a duplicate.
Comment #20
heddnSee #2003540: Rename Views method op_not_ends() to opNotEnds()