Comments

daven’s picture

Assigned: Unassigned » daven

I think I got this one.

daven’s picture

daven’s picture

Assigned: daven » Unassigned
Status: Active » Needs review
elijah lynn’s picture

Status: Needs review » Reviewed & tested by the community

Applies fine and no errors after patching with mild testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-rename-views-methods-2003544-2.patch, failed testing.

daven’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -116,7 +116,7 @@ function op_ends($expression) {
+  function addNotEndsWith($expression) {

Should be "public function addNotEndsWith()"

daven’s picture

Status: Needs work » Needs review
StatusFileSize
new1.74 KB

Attaching new patch with scope modifiers according to Drupal standards.

I now see in the parent issue it's noted that we should be adding the scope on these too: http://drupal.org/node/1856630#comment-6806902

heddn’s picture

Title: Rename Views method op_not_ends() to addNotEndsWith() » Rename Views method op_not_ends() to opNotEndsWith()
Status: Needs review » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opNotEndsWith.

daven’s picture

Command line patching...

curl https://drupal.org/files/drupal-rename-views-methods-2003544-8.patch|git apply
replace addNotEndsWith opNotEndsWith -- Combine.php String.php
daven’s picture

Status: Needs work » Needs review

forgot to set status.

aspilicious’s picture

Status: Needs review » Needs work

Talkes with dawehner about this, should be protected. Srry!

daven’s picture

Status: Needs work » Needs review
StatusFileSize
new1.74 KB
somepal’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a reroll

curl https://drupal.org/files/drupal-rename-views-methods-2003544-13.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1780  100  1780    0     0    685      0  0:00:02  0:00:02 --:--:--   733
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.php:116
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php:89
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/String.php: patch does not apply
daven’s picture

Assigned: Unassigned » daven
daven’s picture

In case I need to do this again:

FILES=`git grep -l 'function op_not_ends'`
sed -i -e 's/function op_not_ends/protected function opNotEndsWith/' -e 's/op_not_ends/opNotEndsWith/' $FILES
git diff
daven’s picture

moving target. this one doesn't apply either. looks like it's been renamed elsewhere.

daven’s picture

Just found https://drupal.org/node/2003540 which means it looks like this issue is a duplicate.

heddn’s picture

Status: Needs work » Closed (duplicate)