Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#3 views-rename-op-equal.patch1.84 KBzschmid
#1 views-rename-op-equal.patch1.84 KBmalcomio

Comments

malcomio’s picture

malcomio commented
Status: Active » Needs review
StatusFileSize
new views-rename-op-equal.patch1.84 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -87,10 +87,10 @@ public function query() {
+  function opEqual($expression) {

Add public access modifier in front of the method to adher to the new OOP standards.

zschmid’s picture

zschmid commented
Assigned: malcomio » zschmid
StatusFileSize
new views-rename-op-equal.patch1.84 KB

Patch for adding public access modifier

zschmid’s picture

zschmid commented
Status: Needs work » Needs review
zschmid’s picture

zschmid commented
Assigned: zschmid » Unassigned

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-rename-op-equal.patch, failed testing.

oenie’s picture

oenie commented
Status: Needs work » Needs review

#3: views-rename-op-equal.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views-rename-op-equal.patch, failed testing.

oenie’s picture

oenie commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#3: views-rename-op-equal.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

dawehner’s picture

dawehner
Primary language German
commented
Title: Rename Views method op_equal() to addEqual() » Rename Views method op_equal() to opEqual()

We should decide first whether we have a proper naming for all this operation query methods and then get them in consistently.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b5411b1 and pushed to 8.x. Thanks!

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

If this is a public API call, then opFoo has zero meaning. Maybe addFoo is wrong but something has to be better than opFoo. Do we mean operation, opportunity, opening post? At least spell it out.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

I guess we can iron out the details about naming after massing conversion.

Automatically closed -- issue fixed for 2 weeks with no activity.