Follow-up for #1658846-187: Add language support to node access grants and records
Original node access issue had inline comments using third person verb tense.
(Don't change the tense of verbs on functions, those should be third person: Tests...)
Change inside functions the inline comments to be Test ... or Verify that..
No UI changes.
No API changes.
In #1658846-187: Add language support to node access grants and records
+++ b/core/modules/node/lib/Drupal/node/Tests/NodeAccessLanguageTest.phpundefined
@@ -61,31 +47,196 @@ function testNodeAccess() {
+ // Tests that access is not granted if requested with no language.
...
+ // Tests that access is not granted if requested with Hungarian language.
...
+ // Tests that access is not granted if requested with no language.
...
+ // Tests that Hungarian is still not accessible.
...
+ // Tests that Catalan is still not accessible.These can all be "Test" or "Verify" or something rather than "Tests". (Ditto for similar comments elsewhere.)
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | modification_in_grammar-10233741-3.patch | 9.94 KB | joyceg |
Comments
Comment #1
gábor hojtsyDo we have standard suggestions for this or is this is an "it feels better"?
Comment #2
joyceg commentedI am working on this issue.
Comment #3
joyceg commentedAdding the patch here.
Comment #4
joyceg commentedComment #5
yesct commentedwe should not go through with this, until at least the remaining task that says "find the standard and link to it" is done.
but even more, we have a new strategy for dealing with coding style only changes: #2571965: [meta] Fix PHP coding standards in core, stage 1
postponing this until:
we have a sniffer running automatically, and we can add a rule that checks this particular standard.
for more background, see #1518116-86: [meta] Make Core pass Coder Review
I would also recommend working on bugs (that do not require api changes). tasks can be tricky to know if they are allowed to be committed depending on the phase of the release we are in.
Comment #17
quietone commentedThe Drupal standards for in-line code comments makes no mention of the tense. The tense is only prescribed for most functions in in Drupal API documentation standards for functions/
Therefor I am closing this as won't fix.