Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
tour.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Feb 2013 at 22:49 UTC
Updated:
29 Jul 2014 at 21:56 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
klonos...bit OT and I don't know if there is an issue already filed for this, but are the Edit and Tour buttons "tied" with the toolbar? What about sites that don't use the toolbar (disabled because they use admin_menu for example) or sites that have mainly anonymous users (those don't see the toolbar by default) and still want to display a tour to their visitors?
Comment #2
echoz commentedScreenshots tabbing to tour button, matching the toolbar link's focus style.
:focus working with less selectors.
Comment #3
mgiffordThis addresses the focus problem that was identified! Unfortunately the tab order is incorrect. It should be visually as it appears:
Home Menu Shortcuts admin Tour
But instead the order is:
Home Menu Shortcuts Tour admin
That can probably be addressed by: #1913086: Generalize the overlay tabbing management into a utility library
But because Tour is visually a long ways from the other tabs it would be useful if on focus it stood out more.
@Bojhan are there any reasons not to do this from a UX perspective?
Comment #4
jessebeach commentedThis patch fixes the problem.
I'd love to keep this issue focused (pun!) and solve related issues in their own tickets.
Comment #5
dcmouyard commentedI prefer to have focus styling be more obvious than just an outline. Keyboard users have vision problems too.
That's a separate issue, so don't let that stop this one. :)
Comment #6
mgiffordJust created a new issue here #1929010: Improve Contrast for onfocus Menu Items
Comment #7
webchickCommitted and pushed to 8.x. Thanks!