Follow up for #1809352-175: Write tour.module and add it to core

Problem/Motivation

Tour toolbar item was changed from link to button, but :focus class/styling not present for keyboard users.

Proposed resolution

Add css to indiciate :focus on button

Remaining tasks

Write patch
Test a11y

User interface changes

:focus class for toolbar tour button

API changes

None

Comments

klonos’s picture

...bit OT and I don't know if there is an issue already filed for this, but are the Edit and Tour buttons "tied" with the toolbar? What about sites that don't use the toolbar (disabled because they use admin_menu for example) or sites that have mainly anonymous users (those don't see the toolbar by default) and still want to display a tour to their visitors?

echoz’s picture

Status: Active » Needs review
StatusFileSize
new5.39 KB
new6.03 KB
new538 bytes

Screenshots tabbing to tour button, matching the toolbar link's focus style.
:focus working with less selectors.

mgifford’s picture

Issue tags: +keyboard focus

This addresses the focus problem that was identified! Unfortunately the tab order is incorrect. It should be visually as it appears:
Home Menu Shortcuts admin Tour

But instead the order is:
Home Menu Shortcuts Tour admin

That can probably be addressed by: #1913086: Generalize the overlay tabbing management into a utility library

But because Tour is visually a long ways from the other tabs it would be useful if on focus it stood out more.

@Bojhan are there any reasons not to do this from a UX perspective?

jessebeach’s picture

Status: Needs review » Reviewed & tested by the community

This patch fixes the problem.

I'd love to keep this issue focused (pun!) and solve related issues in their own tickets.

dcmouyard’s picture

I prefer to have focus styling be more obvious than just an outline. Keyboard users have vision problems too.

That's a separate issue, so don't let that stop this one. :)

mgifford’s picture

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.