$this->drupalGet('alsjdhkjahdkjahsdkjhaskjdhkasd');

That does not return any fails in SimpleTest, and probably should.

Not sure if we could backport this, since it would be a change in behaviour.

CommentFileSizeAuthor
#10 drupal-1574764-10.patch13.51 KBdawehner
#10 interdiff.txt4.23 KBdawehner
#4 1574764-4-update-aggregate-simpletest-to-use-the-new-drupalGet-do-not-test.patch9.26 KBelvis2
#3 1574764-3-call-assertResponse-in-drupalGet.patch4.2 KBelvis2
#2 1574764-2-call-assertResponse-in-drupalGet.patch1.73 KBelvis2

Comments

elvis2’s picture

elvis2 commented
Assigned: Unassigned » elvis2
elvis2’s picture

elvis2 commented
Title: drupalGet() should throw a fail if it gets a non-200 request » Add page response using assertResponse() in drupalGet()
Status: Active » Needs review
StatusFileSize
new 1574764-2-call-assertResponse-in-drupalGet.patch1.73 KB

Changed title.

Attached is a patch that adds two new parameters to the drupalGet() function.

In most of the *Test.php files where drupalGet() is called, within the next few lines, assertResponse() is called. I do not see any harm in keeping the tests the way they are but I would imagine the code would need to be refactored.

Later I will append a patch file to show how the above will change the aggregator module test code.

elvis2’s picture

elvis2 commented
StatusFileSize
new 1574764-3-call-assertResponse-in-drupalGet.patch4.2 KB

A re-roll of #2 - accommodating string vs array check and accepting response codes 200 or 204 when testCron is invoked.

elvis2’s picture

elvis2 commented
StatusFileSize
new 1574764-4-update-aggregate-simpletest-to-use-the-new-drupalGet-do-not-test.patch9.26 KB

The attached patch is an example of how #3 would change uses of drupalGet() within aggregate simpletest code.

When testing locally you need to apply #3 first then this attached patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented 
+++ b/core/modules/aggregator/lib/Drupal/aggregator/Tests/AddFeedTest.phpundefined
@@ -30,11 +30,14 @@ function testAddFeed() {
+    $code = 200;
+    $message = 'Feed source exists.';
+    $this->drupalGet('aggregator/sources/' . $feed->id(), array(), array(), $code, $message);

I would put stuff like this inline.

Status: Needs review » Needs work

The last submitted patch, 1574764-3-call-assertResponse-in-drupalGet.patch, failed testing.

elvis2’s picture

elvis2 commented
Status: Needs work » Needs review

#3: 1574764-3-call-assertResponse-in-drupalGet.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1574764-3-call-assertResponse-in-drupalGet.patch, failed testing.

elvis2’s picture

elvis2 commented
Status: Needs work » Needs review

#3: 1574764-3-call-assertResponse-in-drupalGet.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt4.23 KB
new drupal-1574764-10.patch13.51 KB

This doesn't do anything so far.

Désiré queued 10: drupal-1574764-10.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: drupal-1574764-10.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)