If you attach a file to a node and then create a new revision with the file removed, that file remains in the file system. This is expected behavior, as you would have the ability to revert to that previous revision and still require that file. However, if you delete that first revision (the only one to which that file is attached), the file remains in the file system.
As a test I also performed this same scenario with standard Drupal revisions (without Workbench Moderation), and it does remove the file when that initial revision is deleted.
Comments
Comment #1
Taxoman commentedImportant that this cleanup happens, but equally important that the site admin have a custom setting to disable it on sites where the policy is to retain such files in the file system. Maybe with a new tab showing which files are currently "orphaned"?
Comment #2
dave reidAs far as I can tell, Workbench moderation doesn't handle anything with deletion of revisions - it's entirely Drupal core. The links generated to delete revisions from the Moderation tab point to node/[node:nid]/revisions/[node:vid]/delete which is a core path.
Comment #3
fasdalf@fasdalf.ru commentedThis happens wothout workbench on my 7-10. Is this a core filefield bug?
Comment #4
stevectorI'm not sure of the reasons for core's behavior. I'm changing this to a support request because the file module might be designed to work this way.
Comment #5
amateescu commentedDuplicate of #2393641: File usage records for files referenced in older node revisions are not removed on node deletion. This is "just" a core bug.