It seems to me that the naming of DatabaseTransactionNoActiveException was a typo, or perhaps a non-native speaker naming it. Shouldn't it be DatabaseTransactionNotActiveException?

Patch attached. This is technically an API change. I think it should be brought back to D7... but...

CommentFileSizeAuthor
#5 drupal.databaseExceptionNotActive_1247044_05.patch3 KBrfay
drupal.DatabaseExceptionNotActive.patch2.73 KBrfay

Comments

catch’s picture

catch
he/him
Primary language English
commented

s/NoActive/NotActive makes sense to me. It currently reads like there's no active exception.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

drupal.DatabaseExceptionNotActive.patch queued for re-testing.

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal.DatabaseExceptionNotActive.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.databaseExceptionNotActive_1247044_05.patch3 KB

Reroll after core patch

artusamak’s picture

artusamak
he/him
Primary language French
Location Bzh
commented
Status: Needs review » Reviewed & tested by the community

Sounds ok.

chx’s picture

chx commented
Title: DatabaseTransactionNoActiveException should be DatabaseTransactionNotActiveException » DatabaseTransactionNoActiveException is poorly named
Status: Reviewed & tested by the community » Needs work

No it doesn't. The exception is not about a transaction being in a "not active" state because there is no such beast much rather it says "there is no transaction currently at all". If there is a need for rename then do it but the NotActive sounds incorrect to me.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@chx, would you go with DatabaseNoActiveTransactionException? I do believe that this is thrown when there is *not* an active transaction, which would mean the original proposed rename would work OK, but DatabaseNoActiveTransactionException would work for me too.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)
Issue tags: +Bug Smash Initiative

In #7 it was explained that this is not the same as 'NotActiveException', which suggests this is a won't fix. Then in #8 there was a suggestion to make it DatabaseNoActiveTransactionException. However all the exceptions related to transactions begin with Transaction. as in TransactionNameNonUniqueException. It doesn't make sense to change that pattern. Also, in Jan 2012 this exception was renamed in commit 5a5c830761e2b13640a09c3ba80ed6c4dd0b5fa4 to TransactionNoActiveException.

There isn't anything to fix here, closing as won't fix.