Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It seems to me that the naming of DatabaseTransactionNoActiveException was a typo, or perhaps a non-native speaker naming it. Shouldn't it be DatabaseTransactionNotActiveException?
Patch attached. This is technically an API change. I think it should be brought back to D7... but...
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal.databaseExceptionNotActive_1247044_05.patch | 3 KB | rfay |
drupal.DatabaseExceptionNotActive.patch | 2.73 KB | rfay | |
Comments
Comment #1
catchs/NoActive/NotActive makes sense to me. It currently reads like there's no active exception.
Comment #2
rfaydrupal.DatabaseExceptionNotActive.patch queued for re-testing.
Comment #3
ArtusamakComment #5
rfayReroll after core patch
Comment #6
ArtusamakSounds ok.
Comment #7
chx CreditAttribution: chx commentedNo it doesn't. The exception is not about a transaction being in a "not active" state because there is no such beast much rather it says "there is no transaction currently at all". If there is a need for rename then do it but the NotActive sounds incorrect to me.
Comment #8
rfay@chx, would you go with DatabaseNoActiveTransactionException? I do believe that this is thrown when there is *not* an active transaction, which would mean the original proposed rename would work OK, but DatabaseNoActiveTransactionException would work for me too.
Comment #17
quietone CreditAttribution: quietone as a volunteer commentedIn #7 it was explained that this is not the same as 'NotActiveException', which suggests this is a won't fix. Then in #8 there was a suggestion to make it DatabaseNoActiveTransactionException. However all the exceptions related to transactions begin with Transaction. as in TransactionNameNonUniqueException. It doesn't make sense to change that pattern. Also, in Jan 2012 this exception was renamed in commit 5a5c830761e2b13640a09c3ba80ed6c4dd0b5fa4 to TransactionNoActiveException.
There isn't anything to fix here, closing as won't fix.