Unpublished books can't be reordered at admin/structure/book/[bookid]

Hello guys

I just created a new patch to solve this feature requested.

Please test and let me know if works for you.

Reviwed on drupal contribute Costa Rica

good to go, let's add a nice unit test to the patch :)

Thanks for working on this. A screenshot would help: how can I see if a book is published or not?

Needs some minor code style cleanup, spaces between commas in arrays, spaces between ternary operator, and don't just comment out the old code, remove it.

Code styling improvements.

#7: list-publish-unpublish-books-1184692-7.patch queued for re-testing.

Hi @wjaspers, @ptmkenny,

I have checked this issue still exists in 9.1 dev. So I have created the patch and added screenshots before and after the patch. Please have a look and let me know if there are any issues.

Before Patch:

See the Book and parent item of the node

After Patch:

@ramya thanks for the patch and it is working fine. Would you please add a status column on the page as already done in previous patches.

Hi @sharma.amitt16,

I have addressed your above comments. Please have a look.

After Patch:

+++ b/core/modules/book/src/Form/BookAdminEditForm.php
@@ -148,6 +148,7 @@ protected function bookAdminTable(NodeInterface $node, array &$form) {
         $this->t('Operations'),

@ramya thanks for the change. Small correction, would you please move the operations column after status.

This is not consistent with other content listing with operations.

Hi @sharma.amitt16,

Updated the patch and screenshots.

+++ b/core/modules/book/src/Form/BookAdminEditForm.php
@@ -147,6 +147,7 @@ protected function bookAdminTable(NodeInterface $node, array &$form) {
+        $this->t('Status'),
         $this->t('Operations'),

Now looks good.

Verified and tested by applying the patch #27.It looks good to me.Can be moved to RTBC.

Steps to test -
1. Go to admin site.
2. Go to admin/modules , enable the book module.
3. Go to admin/content.
4. Create 2-3 book content type.
5. Create one of them in unpublished state and other in published state.
6. Go to admin/structure/book.
7. Verify the listing.

Before Patch -

After Patch -

Based on #30.

@@ -959,7 +959,6 @@ public function bookTreeCheckAccess(&$tree, $node_links = []) {
       //   field language and just fall back to the default language.
       $nids = \Drupal::entityQuery('node')
         ->condition('nid', $nids, 'IN')
-        ->condition('status', 1)
         ->execute();
 
       foreach ($nids as $nid) {

Do we need to check that the current user has access to view unpublished nodes? What's the route access for this page?

Also there's no test coverage added with this patch but probably should be.

Hi @catch,
Thanks. Sorry for the delayed reply. I have checked your comment and already there is one issue related to access to unpublished nodes (https://www.drupal.org/project/drupal/issues/26552). And in this issue https://www.drupal.org/project/drupal/issues/26552, in the last updated patch(https://www.drupal.org/files/issues/2020-03-18/26552-156.patch) they have added test cases for listing book pages testAdminBookListing, testAdminBookNodeListing.

Is this enough or do we need to create seperate test cases for this issue also? Please let me know.

Updated title and issue summary - admin/content/book does not seem to exist, I worked out what is going on though :)

Changing to a bug, not a feature request as there is no reason this shouldn't work for unpublished content.

1. +++ b/core/modules/book/src/Form/BookAdminEditForm.php
   @@ -211,6 +212,7 @@ protected function bookAdminTableTree(array $tree, array &$form) {
   +      $node = \Drupal\node\Entity\Node::load($nid);
   

   Use $this->nodeStorage->load() instead

2. +++ b/core/modules/book/src/Form/BookAdminEditForm.php
   @@ -267,6 +269,11 @@ protected function bookAdminTableTree(array $tree, array &$form) {
   +      $form[$id]['status'] = [
   +        '#type' => 'markup',
   +        '#markup'=> $node->isPublished() ? 'Published' : 'Unpublished',
   
   @@ -288,6 +295,11 @@ protected function bookAdminTableTree(array $tree, array &$form) {
   +      $form[$id]['status'] = [
   +        '#type' => 'markup',
   +        '#markup'=> $node->isPublished() ? 'Published' : 'Unpublished',
   

   Overall not sure it's needed but

   - no reason to duplicate status column
   - strings should use $this->t() to be translatabe

I have uploaded the patch.
Addressed #42 both points,
Rerolled against 10.1x

I cannot reproduce this on 10.1 following the steps in the issue summary. It might be worth noting that I was logged in as user 1, do we need to use a certain role with certain permissions. Can someone who can reproduce this please provide updated steps to reproduce?

Furthermore we need a failing test to confirm this behaviour.

I tested this on Drupal 10.1.x, standard install. I used the steps in the Issue Summary. First, I tested with the admin user and I was not able to reproduce the problem. Next, I created a user that had permission to create books, edit own books, administer content, view own unpublished content and the necessary admin book permissions. Again, I could not produce the error.

This may have been fixed as part of #26552: Allow users with access to unpublished nodes to create unpublished books but #21 and the testing just after suggests otherwise.

Therefore, closing as outdated. If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

Thanks!