Date arguments and filters on relationships do (may?) not work. This is because of the use of queue_table instead of ensure_table. queue_table does not ensure that the path leads back to the relationship table.

CommentFileSizeAuthor
#6 date_arg_and_relationships-1289270-6.patch1.93 KBarlinsandbulte
#1 fix_table_relationship_bug-1289270-1-D6.patch1.7 KBpdrake

Comments

pdrake’s picture

pdrake commented
StatusFileSize
new fix_table_relationship_bug-1289270-1-D6.patch1.7 KB

Thanks to dereine for the solution to this problem. See attached for a patch which solves the issue by replacing the queue_table function calls with ensure_table calls.

dawehner’s picture

dawehner
Primary language German
commented 
  /**
   * Add a table to the query without ensuring the path.
   *
   * This is a pretty internal function to Views and add_table() or
   * ensure_table() should be used instead of this one, unless you are
   * absolutely sure this is what you want.
   *
...
  function queue_table($table, $relationship = NULL, $join = NULL, $alias = NULL) {

Just a little quote

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review

Update status

Encarte’s picture

Encarte commented

subscribing

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Reviewed & tested by the community

@dawehner I was just about to make this exact change after we saw this bug and I read that doxy comment for queue_table() =)

@pdrake++ # for making this patch 7+ months ago

This is still applicable on the 6.x-2.9, and passing testing here - marking RTBC

arlinsandbulte’s picture

arlinsandbulte commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new date_arg_and_relationships-1289270-6.patch1.93 KB

Looks like the same problem might exist in 7.x-2.x.
Let's first make sure this is fixed there before applying to 6.x

ported patch attached.
Let's see what testbot thinks.

arlinsandbulte’s picture

arlinsandbulte commented
Status: Needs review » Fixed

OK, Committed to 7.x-2.x & 6.x-2.x branches:
7.x-2.x commit: http://drupalcode.org/project/date.git/commit/614b4e6
6.x-2.x commit: http://drupalcode.org/project/date.git/commit/45d7f7c

Also committed to Date 7.x-3.x sandbox:
http://drupalcode.org/sandbox/karens/1512146.git/commit/07e820a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.