Problem/Motivation

The data module cannot be loaded (from admin UI) in Drupal 9, due to it being listed as Drupal 8. This prevents development, since the Drupal 8 module has not been completed.

Proposed resolution

Add a single line to data.info.yml - patch attached.

Remaining tasks

- Review by maintainers is there a better way for this?

CommentFileSizeAuthor
#2 3160612-02.patch282 bytesrobertwb

Issue fork data-3160612

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

robertwb created an issue. See original summary.

robertwb’s picture

robertwb commented
StatusFileSize
new 3160612-02.patch282 bytes
robertwb’s picture

robertwb commented
Title: .info file must enable core version 9 for Drupal 9 testing/development » data.info.yml must enable core version 9 for Drupal 9 testing/development
mlncn’s picture

mlncn commented
Status: Active » Reviewed & tested by the community

valthebald made their first commit to this issue’s fork.

valthebald opened merge request !1

valthebald’s picture

valthebald
Location Sofia
commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x-1.x, thank you!

valthebald closed merge request !1

dave kopecek’s picture

dave kopecek
he/him
commented

This is marked as closed but it doesn't look like the changes were merged into 8.x-1.x
See https://git.drupalcode.org/project/data/-/merge_requests/1

Last commit was:
29 Jan, 2020 1 commit
valthebald's avatar
Issue #3088972 by rpayanm, Sahana _N: Drupal 9 plan
valthebald authored 1 year ago
94a7deb1

dave kopecek’s picture

dave kopecek
he/him
commented
Status: Fixed » Needs review
pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

yes, it was pushed into the issue fork 8.x-1.x branch.
https://git.drupalcode.org/issue/data-3160612/-/commits/8.x-1.x

It needs to be pushed to the main module repository.
Project maintainers should have a gray merge button at the bottom of the issue. That button should be used.
more info: https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

andriyun’s picture

andriyun commented

Hi mates
I can confirm. There is not changes in MR https://git.drupalcode.org/project/data/-/merge_requests/1
8.x-1.x branch still have to line that allows using of data module on Drupal9 :)

Looks like it has to be done via old school way with patch adding
https://www.drupal.org/project/data/issues/3160612#comment-13757866

andriyun’s picture

andriyun commented
Status: Needs review » Reviewed & tested by the community
andriyun’s picture

andriyun commented
Status: Reviewed & tested by the community » Needs review

I looked more on issues list and see that it might better to focus on issue #3091460: Deprecations removal. Drupal 9 readiness
and mark this one as duplicated.
Both patches were added in about the same time and patch #8 from 3091460
Adding more value to project

What do you think @valthebald ?

valthebald’s picture

valthebald
Location Sofia
commented

Looks like I had a soaped eye - the issue is definitely not fixed :(
One addition to the patch from #2 is to remove core line, and replace it with core_version_requirement

valthebald’s picture

valthebald
Location Sofia
commented

  • valthebald committed 68209dd on 8.x-1.x 
    Issue #3160612 by valthebald, robertwb, andr1yun: data.info.yml must...
valthebald’s picture

valthebald
Location Sofia
commented

@andr1yun: I prefer the smaller issues when possible, so maybe let's handle #3091460: Deprecations removal. Drupal 9 readiness separately?

valthebald’s picture

valthebald
Location Sofia
commented
Priority: Critical » Normal
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.