Problem/Motivation
FILE: ...trib/modules/ctools/tests/src/Kernel/RelationshipManagerTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
22 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: "foo"
23 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: ]
46 | WARNING | [x] There must be no blank line following an inline
| | comment
46 | WARNING | [ ] There must be no blank line following an inline
| | comment
46 | ERROR | [x] No space found before comment text; expected "//
| | $this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
| | but found
| | "//$this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
46 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
60 | ERROR | [x] No space found before comment text; expected "//
| | $this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
| | but found
| | "//$this->assertTrue(isset($definitions['typed_data_relationship:entity:node:body']));"
60 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3033303-9.patch | 1.25 KB | andregp |
| #5 | 3033303-5.patch | 1.06 KB | shreyakaushik11 |
| #3 | ctools-Standards_on_Kernel_RelationshipManagerTest-3033303-3-D8.patch | 1.65 KB | thalles |
Comments
Comment #2
thallesFollow the patch!
Comment #3
thallesComment #4
chris matthews commentedThe 2 year old patch in #3 needs a reroll.
Comment #5
shreyakaushik11 commentedI've rerolled the patch mentioned in #3.
Please review.
Comment #6
guilhermevp commentedRe-rolled patch looks good, most of patch #3 ended addressed in other issues.
Comment #7
joelpittetThe two lines being ignored need a git blame to figure out why they are commented out code to begin with, and better yet would be to uncomment them and see if they still break.
Comment #8
andregp commentedI found where this came from, I'll comment here the details. Just one sec.
Comment #9
andregp commentedThese two lines were commented out on commit c14a5eee from May 6th, 2016.
The commit message says:
commenting out two tests until #2671964 landsWith further research I found this:
https://git.drupalcode.org/project/ctools/-/commit/c14a5eee970c3d0aab02e...
and https://www.drupal.org/node/2671964 which was fixed so I think its okay to uncomment these lines.
Comment #10
victoria-marina commentedComment #11
victoria-marina commentedLooks good! It's a RTBC for me.
Comment #12
japerry