Problem/Motivation

FILE: .../ctools_wizard_test/src/Form/ExampleConfigEntityExternalForm.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------
  3 | ERROR | [x] There must be one blank line after the namespace
    |       |     declaration
 11 | ERROR | [x] Missing class doc comment
 23 | ERROR | [ ] Missing parameter comment
 25 | ERROR | [x] Visibility must be declared on method "__construct"
 48 | ERROR | [ ] Inline doc block comments are not allowed; use "/*
    |       |     Comment */" or "// Comment" instead
 65 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
CommentFileSizeAuthor
#6 ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-6-D8.patch1.25 KBthalles
#5 ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-5-D8.patch900 bytesthalles
#3 ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-3-D8.patch1.77 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-3-D8.patch1.77 KB

Follow!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented 
+++ b/tests/modules/ctools_wizard_test/src/Form/ExampleConfigEntityExternalForm.php
@@ -45,7 +48,7 @@ class ExampleConfigEntityExternalForm extends FormBase {
-    /** @var $page \Drupal\ctools_wizard_test\Entity\ExampleConfigEntity */
+    /* @var $page \Drupal\ctools_wizard_test\Entity\ExampleConfigEntity */

I don't mind committing this because it's a test but this line may be a false positive. https://www.drupal.org/project/coder/issues/2236393#comment-12974822

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-5-D8.patch900 bytes

Thanks Joel!
Follow!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-6-D8.patch1.25 KB

Follow!

The last submitted patch, 5: ctools-Standards_on_Form_ExampleConfigEntityExternalForm-3033299-5-D8.patch, failed testing. View results

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thanks @thalles! Committed to the -dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.