web/modules/contrib/ctools/src/Plugin/Deriver/TypedDataRelationshipDeriver.php:38
$derivative['data_type'] = $property_definition->getFieldStorageDefinition()->getPropertyDefinition($property_definition->getFieldStorageDefinition()->getMainPropertyName())->getDataType();
getMainPropertyName() can, validly, return NULL (see \Drupal\Core\Field\FieldItemInterface::mainPropertyName).
It can also invalidly return a property that doesn't exist (for example address field doesn't have value but doesn't override mainPropertyName). Not sure if we want to account for this by ensuring the property also exists?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2865709-5.patch | 2.46 KB | shreyakaushik11 |
| #2 | 2865709-fix_relationship_deriver_fatal_on_no_main_property.patch | 2.36 KB | andrewbelcher |
Comments
Comment #2
andrewbelcher commentedHere is a patch that fixes the deriver issue. I tried writing a test using the map field item, but that gave core errors on trying to install... If it's important to test, we may have to write our own field type to test with.
Bumping to major as it will currently break any page that uses the relationship manager when there is an address field...
Comment #3
pfrenssenI'm also hitting this bug.
The "map" field type has no main property, this could be used in the test.
Ref.
\Drupal\Core\Field\Plugin\Field\FieldType\MapItem::mainPropertyName()Comment #4
chris matthews commentedThe 4 year old patch in #2 needs a reroll.
Comment #5
shreyakaushik11 commentedI've rerolled the patch mentioned in #2.
Please review.