Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sandeep_singh created an issue. See original summary.

Bmuskan’s picture

Issue summary: View changes
FileSize
19.37 KB
25.2 KB

Add code of some libraries in .info.yml file:

#Libraries
libraries:
  - creative_responsive_theme/bootstrap
  - creative_responsive_theme/global-components
  - creative_responsive_theme/font-awesome
  - creative_responsive_theme/fonts

Also add some code in libraries.yml file:

font-awesome:
  remote: https://use.fontawesome.com/releases/v5.6.3/css/all.css:
  version: 4.5.0
  license:
    name: MIT
    url: https://fortawesome.github.io/Font-Awesome/license/
    gpl-compatible: true
  css:
    theme:
        https://use.fontawesome.com/releases/v5.1.0/css/all.css: { type: external, minified: true }   
fonts:
  css:
    theme:
      https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css: { type: external, minified: true }
global-components:
  Version: 1.x

I have also attached screenshot here.

sandeep_singh’s picture

Title: Social media icons and website logo not visible on frontend » Social media icons not visible on frontend
Issue summary: View changes
Bmuskan’s picture

Issue summary: View changes
Status: Active » Needs review
reinaldoc’s picture

just copy "fonts" directory from industrial_zymphonies_theme

Harsh panchal’s picture

I have fixed Social media icons not visible on frontend issue and apply patch.

atul_ghate’s picture

Assigned: Harsh panchal » atul_ghate

Hi,
i will review this patch.

atul_ghate’s picture

After applying this patch, it shows some whitespace issues, and I am not able to see the icon on the front page after applying this patch.

/var/www/html/oslando/web/themes/contrib/creative-responsive-theme/Social-media-icons-not-visible-on-frontend-3244316-6.patch:80: trailing whitespace.
/var/www/html/oslando/web/themes/contrib/creative-responsive-theme/Social-media-icons-not-visible-on-frontend-3244316-6.patch:94: trailing whitespace.
/var/www/html/oslando/web/themes/contrib/creative-responsive-theme/Social-media-icons-not-visible-on-frontend-3244316-6.patch:109: trailing whitespace.
/var/www/html/oslando/web/themes/contrib/creative-responsive-theme/Social-media-icons-not-visible-on-frontend-3244316-6.patch:115: trailing whitespace.
/var/www/html/oslando/web/themes/contrib/creative-responsive-theme/Social-media-icons-not-visible-on-frontend-3244316-6.patch:123: trailing whitespace.
Checking patch css/font-awesome.css...
Checking patch templates/layout/page.html.twig...
Checking patch webfoI Have applied this patch , it is showing some whitspace issues and after applying this patch still i am not able to see icon on frontpagents/fa-brands-400.svg...
Checking patch webfonts/fa-regular-400.svg...
Checking patch webfonts/fa-solid-900.svg...
Applied patch css/font-awesome.css cleanly.
Applied patch templates/layout/page.html.twig cleanly.
Applied patch webfonts/fa-brands-400.svg cleanly.
Applied patch webfonts/fa-regular-400.svg cleanly.
Applied patch webfonts/fa-solid-900.svg cleanly.
warning: squelched 1606 whitespace errors
warning: 1611 lines add whitespace errors.

atul_ghate’s picture

Assigned: atul_ghate » Unassigned