Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
see the patch below.
Comment | File | Size | Author |
---|---|---|---|
#6 | corner-478148-2.patch | 19.73 KB | tobiasb |
#5 | corner-478148-1.patch | 2.72 KB | tobiasb |
#1 | corner-478148.patch | 2.5 KB | tobiasb |
Comments
Comment #1
tobiasbComment #2
tobiasbComment #3
tobiasbComment #4
kirie CreditAttribution: kirie commentedThanks for the patch! However, after applying the patch the example corner is no longer inserted into the db at install time. It seems that
drupal_get_schema
can't be used during install (its used bydrupal_write_record
) - not too sure about this though.Comment #5
tobiasbRight. devels re-install funktion is not the right way to test the install process. here the old way via db_query.
Comment #6
tobiasbComment #7
tobiasbadd more validation and so on
rename polygon (wrong in output shape="polygon") -> shape="poly" / shape="rect"
Comment #8
kirie CreditAttribution: kirie commentedHello and thanks for the awesome work! I've committed the patch to the 6.x-2.x branch, with the following modifications:
- Made "Corner link target" into a select and removed tha validation of the field
- Removed all "return" statements from "form_set_error"
- Removed the hard-coded
<em>
tags in the error message and used % in thet()
function instead- Capitalized comments + minor language fixes
Comment #9
kirie CreditAttribution: kirie commented