see the patch below.

CommentFileSizeAuthor
#6 corner-478148-2.patch19.73 KBtobiasb
#5 corner-478148-1.patch2.72 KBtobiasb
#1 corner-478148.patch2.5 KBtobiasb

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new corner-478148.patch2.5 KB
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs work
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
kirie’s picture

kirie commented
Status: Needs review » Needs work

Thanks for the patch! However, after applying the patch the example corner is no longer inserted into the db at install time. It seems that drupal_get_schema can't be used during install (its used by drupal_write_record) - not too sure about this though.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Needs work » Needs review
StatusFileSize
new corner-478148-1.patch2.72 KB

Right. devels re-install funktion is not the right way to test the install process. here the old way via db_query.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new corner-478148-2.patch19.73 KB
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

add more validation and so on

rename polygon (wrong in output shape="polygon") -> shape="poly" / shape="rect"

kirie’s picture

kirie commented

Hello and thanks for the awesome work! I've committed the patch to the 6.x-2.x branch, with the following modifications:
- Made "Corner link target" into a select and removed tha validation of the field
- Removed all "return" statements from "form_set_error"
- Removed the hard-coded <em> tags in the error message and used % in the t() function instead
- Capitalized comments + minor language fixes

kirie’s picture

kirie commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.