Problem/Motivation

The preview shows up randomly

Proposed resolution

Allow positioning

Remaining tasks

Review

User interface changes

API changes

Data model changes

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Assigned: Unassigned » larowlan
larowlan’s picture

Status: Active » Needs review
StatusFileSize
new1.36 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2717051-preview-positioning.patch, failed testing.

benjy’s picture

Looks good to me once green.

+++ b/contact_storage.module
@@ -187,3 +187,18 @@ function contact_storage_entity_type_alter(array &$entity_types) {
+  foreach (array_keys(entity_get_bundles('contact_message')) as $bundle) {

Not sure if you want to use \Drupal::service('entity_type.bundle.info')->getBundleInfo($entity_type);

larowlan’s picture

Status: Needs work » Needs review
StatusFileSize
new1.39 KB
new0 bytes

Fixed failing test

Fixes #5

Status: Needs review » Needs work

The last submitted patch, 6: 2717051-preview-positioning.2.patch, failed testing.

larowlan’s picture

Status: Needs work » Needs review
StatusFileSize
new1.71 KB

  • larowlan committed 38a0738 on 8.x-1.x
    Issue #2717051 by larowlan, benjy: Allow previewed message to be...
  • larowlan committed c48ef06 on 8.x-1.x
    Issue #2717051 by larowlan, benjy: Allow previewed message to be...
larowlan’s picture

Status: Needs review » Fixed
andypost’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.