Replace use of $definition['label'] with t($definition['label]). Those labels as part of the schema should be part of the software thanks to #1935192: Support for Drupal 8 shipped configuration schema translatables in potx.

CommentFileSizeAuthor
#5 1936212-translate-config-label-5.patch1.67 KBvijaycs85
#4 1936212-translate-config-label-4.patch10.6 KBvijaycs85
#1 1936212-translate-config-label-1.patch2.8 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1936212-translate-config-label-1.patch2.8 KB

Here is the patch...

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community

Looks good to me :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Needs work

This does not apply anymore, since I stepped on your toes and made some other commits. Can you reroll *and* then commit yourself? :)

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
FileSize
1936212-translate-config-label-4.patch10.6 KB

Updating patch...

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
1936212-translate-config-label-5.patch1.67 KB

Ignore patch in #4. Here is the patch for this issue.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Thanks, committed, pushed.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.