Hi,
Is there plans to introduce D8 version of this module?
We (@InternetDevels team) would like to help you with development of this version.
Thanks, id_Matvey.

Comments

anavarre’s picture

@pbull and myself are working on a D8 port. We have an initial working version in a private sandbox and will check in here with a link to a public D8 port soon.

anavarre’s picture

We now have a working D8 port. By the end of the week we'll try and see if we can add some tests as well. In any case, we'll try to get a public GitHub sandbox ready by early next week.

anavarre’s picture

Status: Active » Needs review

As promised, here's a link to a public sandbox: https://github.com/anavarre/compact_forms

It simply mimics the module behavior in the D7 version and adds tests. More tests to come in the next iteration.

anavarre’s picture

As an update, SimpleTest now reports 104 passes, 0 fails, 0 exceptions, 19 debug messages. Testers welcome!

anavarre’s picture

Quick update to let people know that @pbull and I have updated the module so that it's compatible with the latest changes in core as of 2015-02-17.

flux423’s picture

Thanks for your work so far!
Any plans on moving this over to drupal.org so we can add 8.x issues?

I'd like to contribute a patch for supporting input[type=tel] fields but not sure if github is the best place to do so.

anavarre’s picture

@flux423: we'd love to, but @sun was no longer responsive when we contacted him to merge the branch back to d.o. so I don't know if there's gonna be any movement soon or if this module is gonna be eligible to https://www.drupal.org/node/251466 instead.

flux423’s picture

Thank you @anavarre for responding and your dev time so far!

Since it's been more than 2 weeks (2 years) and @sun has not responded, should we move this issue to "Drupal.org project ownership" and change the component field to "Abandoned/unsupported projects" as the document suggests?

anavarre’s picture

I think the very first thing would be for someone to contact @sun and give him the opportunity to finally answer. Without any response within a month (?), then yes, I think we should see if there's a volunteer to be a maintainer.

flux423’s picture

Thank you @anavarre. I contacted @sun earlier today with a request to contact you or @pbull to discuss co-maintenance. I would also be happy to share the responsibility.

We'll revisit this issue in a month. I appreciate your advise!

ipwa’s picture

Guys, let us know how it went.

anavarre’s picture

FWIW I didn't get any message from @sun

flux423’s picture

I also did not receive anything from @sun yet.

hoporr’s picture

@anavarre @ flux423
Have you tried contacting Daniel (sun) at his more recent company "netzstrategen"? His email is listed there on the site.

hoporr’s picture

So how do you go about posting issues against the D8 version (on github)? I don't see an 8-branch listed in the main module page, or am I missing something?

Here is something that I noticed in the current module, and would like to post an issue:
When there are multiple languages, the configs are being accessed inconsistently in .module and in the admin-form, and yield different settings.

  1. In .module: \Drupal::config('compact_forms.settings')->get('compact_forms_ids')
  2. In the form: $this->config('compact_forms.settings') where $this refers to Drupal\Core\Form\FormStateInterface.

#1 gets the English config, when the site is using English ( in the DB: collection=language.en ). This setting is generated apparently as a default, and can't be updated
#2 always gets a language independent config. Thereby, the existing English setting can never be updated.

We need to make this consistent. Either allow for language-dependent settings, or one setting for all languages. My preferences is the later, and I wrote the fix in my local install along those lines.

anavarre’s picture

I committed a change on the Github repo to make the module ready with all the deprecated APIs and the switch to BrowserTestBase as a best practice for tests. Things look fairly okay in my testing.

https://github.com/anavarre/compact_forms/commit/b0c11e831ba09213810e661...

Contacted @sun one last time at his new work address to give him the opportunity to say yay or nay. Without any response I will take the module over with Dom. as co-maintainer but I'd rather have someone else really committed to maintain it long term TBH.

Also, we would only maintain the D8 branch and would need someone willing to maintain the D7 branch.

DigitalFrontiersMedia’s picture

Status: Needs review » Fixed

Marking this as Fixed since it has been 5 years since this was active and the module works with Drupal 8.

However, with Drupal 8 being EOL now, those interested in this functionality should push the maintainers to adopt Drupal 9 compatibility. There is an active Pull Request for this fix here at the maintainers' GitHub repo: Changes required to fix compatibility with Drupal 9

ipwa’s picture

Assigned: Unassigned » ipwa
Status: Fixed » Active

This is not fixed because the Drupal 8 version is not in drupal.org yet, I will open a new ticket offering to maintain this project so I can add the Drupal 8 version and make a new release.

DigitalFrontiersMedia’s picture

Ah. Understood. Sorry.