It has been proposed that some rules conditions for the module commerce_physical be added to Commerce Rules Extra. Moving that discussion to this issue.

See #1344962: Add some helpful rules conditions

Comments

MarcElbichon’s picture

MarcElbichon commented

I'm agree to incorporate these rules in CRE but you need to be sure they won't be implemented in commerce_physical module.
Are you agree to be maintainer for these rules because i have never dealt with this module.

Can you post code to initiate the implemenation ?

perignon’s picture

perignon commented

I am pinging that thread...

deggertsen’s picture

deggertsen commented

I would be willing to help maintain these rules as it shouldn't be much trouble. It seems unlikely that these will be added to commerce_physical as the last commit for that module was in 2011.

perignon’s picture

perignon commented

I have to agree with you. I don't think Ryan will be making changes to that module. So lets bring the capability over to this module, I would love to have it here. I just added a new rule today to the module for matching partial SKUs.

I have a very vested interest in Commerce so...

perignon’s picture

perignon commented

I see you have done a tremendous amount of work patching the other module. Do you want to dive into this? I'll be more than willing to do it but after looking at that other thread you were the top contributor by a large margin.

If you are willing. Work against the dev branch in Git. I am about to deploy the dev branch to my production website that gets 3k to 5k visits a day. If I see no issues on my own site I will see about creating a fully fledged release for 2.x.

deggertsen’s picture

deggertsen commented

@Perignon. Are you suggesting I post a patch here? Just a bit of clarification... I'd be happy to do that as soon as I have some time. Unfortunately my brother just died so this week is a bit out of the picture for me. I can try to get to it in the next few weeks though.

perignon’s picture

perignon commented

@deggersten You have my sympathies, very sorry to hear about your brother.

But yeah, you can post a patch here in this thread.

perignon’s picture

perignon commented
Status: Active » Postponed

Postponing till we get some movement on this. We'll reopen this when we get some patches posted.

deggertsen’s picture

deggertsen commented
Status: Postponed » Fixed

Actually, seeing as this was committed to Commerce Physical this issue is fixed.

See #1344962: Add some helpful rules conditions

perignon’s picture

perignon commented

Thanks for the update.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.