Sales Report - Register Choice

Excellent point @fergy. I'll check it out.

Added a filter to select the register so we can view all the sales of a particular store or stores.

Can you move the register option to be beside the date filter, otherwise looks good!

Done. Moved the register next to the date and the submit button as well.

Would definitely help if I uploaded the patch eh!!! :)

2 more formatting things.

The register box is too narrow, even with a short name it is cut off.

Also, if you pick a custom date option it goes a bit wonky, see screenshot

Good Catch! Fixed it as best as I could. See attached.

+++ b/modules/report/includes/commerce_pos_report.pages.inc
@@ -1458,6 +1463,40 @@ function commerce_pos_report_sales_report($form, &$form_state) {
+    foreach ($register_options as $location_name => $register_info) {
+      foreach ($register_info as $id => $name) {
+        $register_ids[] = $id;
+      }
+    }
...
+    else {
+      // Fall back to using the first register ID.
+      $register_id = $register_ids[0];
+    }

We are using nested foreach to get all register_ids.

But using only first register id in our code. IMO if we are going to use only first register id then there's no point in looping over to get all register ids. But, If I am wrong then please share the reason so that it would enhance my knowledge.

Other than that, UI wise it is looking good on my test site.

Thanks

We have no idea what the register ID is right, so we need the register_ids array.

Okay then, patch in #9 is working as expected. Therefore, setting it to RTBC.

Thanks All