Postponed
Project:
Commerce Point of Sale (POS)
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Aug 2017 at 23:22 UTC
Updated:
3 Jan 2018 at 01:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sorabh.v6Comment #3
sorabh.v6This patch includes code for -
1. Sales report menu link.
2. Sales report form (Need to work more on it)
3. Libraries yml file for attaching CSS and js in the module.
4. CSS files from 7.x-2.x version(I thought they can be reused).
5. JS files from 7.x-2.x version(I thought they can be reused).
Need feedbacks.
Comment #4
swickham commentedLooks like a lot of stuff here is just trying to quickly move over the existing CSS and JS files as well as building a filtering form from scratch. The better route to go here is first plan out with Rakesh or McCabe how this part of the port will be done. Once a game plan is in place start attacking smaller pieces from there now knowing what we're going for.
Comment #5
sorabh.v6Comment #6
smccabe commentedMostly a straight port is ok, but the one big thing is to use the new commerce_reports module https://www.drupal.org/project/commerce_reports which has a nice extendable framework so we shouldn't have to build as much scaffolding and UI custom.
Comment #7
sorabh.v6Ok, I'll use commerce reports. Would features be similar to d7 module?
Comment #8
smccabe commentedYup, the features of the report should be the same, no functionality changes, just new architecture
Comment #9
sorabh.v6@smccabe
In D7 sales report has columns -
Cashier Id
Cashier
Net Sales
Transactions
Items sold
Unit per transaction
$ per transaction
But in D8 commerce_report module provide us -
Order report title
amount
tax amount
shipping amount
Which is different from what we need in the sales report. So, I need to why are we using commerce reports as dependency.
Also, there are bugs #2910129: Order report not getting order number in label() method, #2910190: PriceTwigExtension::formatPrice() should accept empty values and #2910199: Table header order and row data order not matching in sales report for which I have created issues on the project page.
Comment #10
sorabh.v6I am uploading patch. This patch is incomplete, I will need guidance to move forward.
Comment #11
sorabh.v6Comment #12
smccabe commentedCommerce reports needs to get a bit farther along before we can continue work on this.