Problem/Motivation

Add test for the Product source plugin.

Proposed resolution

Write the tests. Since the source plugin extends Node just copy from NodeTest as a start.

Remaining tasks

Patch
review
commit

CommentFileSizeAuthor
#4 interdiff.txt1.2 KBquietone
#4 2961589-4.patch10.11 KBquietone
#2 2961589-2.patch8.78 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2961589-2.patch8.78 KB

The patch using data from d6/NodeTest.

quietone’s picture

quietone commented
Parent issue: #2961346: Add Attribute and Attribute Value source plugin test » #2958323: [Meta] Add tests for source plugins with db source
quietone’s picture

quietone commented
StatusFileSize
new 2961589-4.patch10.11 KB
new interdiff.txt1.2 KB

Remove duplicates from fields() method and a line using a source property that does not exist and therefor did nothing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Did a review of the tests. Seems valid. I was going to ask a couple questions, then kept reading and answered them myself.

  • heddn committed 9def146 on 8.x-2.x authored by quietone 
    Issue #2961589 by quietone, heddn: Add Product source plugin test
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.