Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
All the SQL based source plugins should have a test and many do not. This issue is to track what needs to be done.
Using filenames, these are the source plugins that do not have a test.
Commerce - d7 source
- BillingProfile - #2966212: Add billing profile source plugin test
- Field.php - #2966204: Add field source plugin test
- Message.php - #2966189: Add Message source plugin test
- Order.php - #2966205: Add order source plugin test
- PaymentTransaction - #2966207: Add payment transaction source plugin test
- ProductDisplayType - #2966208: Add product display type source plugin test
- ProductVariations - #2966209: Add product variations source plugin test
- Currency.php - #2965905: Add Currency source plugin test
- OrderItemType - #2966201: Add order item type source plugin test
- ProductDisplay - #2966210: Add product display source plugin test
- ViewMode - #2965881: Add ViewMode source plugin test
Ubercart 6
- Attribute and AttributeValue - #2961346: Add Attribute and Attribute Value source plugin test
- Order - #2962640: Add Order source plugin test
- Product - #2961589: Add Product source plugin test
- ViewMode - #2961591: Add ViewMode source plugin test
- Currency - #2965833: Add Currency source plugin test
- Store - #2965848: Add store source plugin test
- TaxType - #2965849: Add tax type source plugin test
Discovered more that are needed and made child issues for them as it was simpler and they are the last ones.
Proposed resolution
Make a new issue for each source plugin test
Remaining tasks
Write all the tests!
Comments
Comment #2
heddnComment #3
quietone commentedAdd issue numbers to IS
Comment #4
quietone commentedComment #5
quietone commentedAdd Commerce view mode test and currency test
Comment #6
quietone commentedComment #7
quietone commentedThese three require a store and/or currency on the destination. Not sure how to do that, or if it is possible in MigrateSqlSourceTestBase.
Field.php - #2966204: Add field source plugin test
Order.php - #2966205: Add order source plugin test
ProductDisplay - #2966210: Add product display source plugin test
ProductVariations - #2966209: Add product variations source plugin test
Comment #8
quietone commentedNice - Ubercart has a complete set of source plugin tests
Small milestone, now have patches for all the remaining source plugins.
Comment #9
quietone commentedHad a look last night and I see possible gaps for the following.
Commerce1 - ProfileTypeTest, ShippingFlatRate
Ubercart7 - ViewMode, Field, Producttype, PVType
Ubercart - Profile billing
Comment #10
quietone commentedCommerce1 - ProfileTypeTest, ShippingFlatRate - fixed
Found a bug in the Commerce 1 Profile/Profile Revision plugins where it isn't using the static JOIN. Still need to make an issue for that
For Ubercart, there are still some missing tests and it looks like several of the source plugins can be combined, for example, product and product variataion
Comment #11
quietone commentedComment #12
quietone commentedAll source plugin with a db source now have tests.