@heddn asked me to post this issue, something he saw while reviewing lots of issues.

MigrateOrderItem::postRowSave should not call addItem because that causes the price to be re-calculated. Instead order_items->get(apendItems)->($order_item);

I'm adding a related issue about removing the postRowSave events.

CommentFileSizeAuthor
#2 2918538-2.patch764 bytesquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2918538-2.patch764 bytes

I implemented this while looking at the order time issue #2916939: Add completion time to orders, document changed time behaviour. While I still think the postRowSave events are not needed, posting this for discussion.

edit: s/are needed/are not needed/

Status: Needs review » Needs work

The last submitted patch, 2: 2918538-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review

Tests passes so setting to NR

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • heddn committed 75b6167 on 8.x-2.x authored by quietone 
    Issue #2918538 by quietone, heddn: MigrateOrderItem should not call...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.