Wanted to check if the postRowSave event subscribers are still needed and if we can remove that code. (Less code to maintain etc etc.) Some local testing suggests they are not. But let's run the full set of tests.

CommentFileSizeAuthor
#6 2917891-6.patch1.9 KBquietone
#4 2917891-4.patch5.3 KBquietone
#2 2917891-2.patch5.24 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2917891-2.patch5.24 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2917891-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2917891-4.patch5.3 KB

Reroll.

Status: Needs review » Needs work

The last submitted patch, 4: 2917891-4.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2917891-6.patch1.9 KB

another reroll

quietone’s picture

quietone commented
Status: Needs review » Postponed

Let's postpone this until the way to handle rollbacks, and thus the dependency of product/product variations and order/order items, is resolved .

quietone’s picture

quietone commented
Status: Postponed » Closed (outdated)

The postRowSave was removed in #2950104: inconsistency in relationship between order/order item migrations for different sources.