This is to implement to the first step for commerce migration sub modules as suggested in the parent issue.

The initial and most obvious use case for this, in my opinion, is to add a phone number field to profiles and then include the billing_phone field from ubercart when creating a profile.

CommentFileSizeAuthor
#8 interdiff.txt1019 bytesquietone
#8 2890311-8.patch15.61 KBquietone
#6 interdiff.txt2.15 KBquietone
#6 2890311-6.patch14.48 KBquietone
#4 interdiff.txt2.78 KBquietone
#4 2890311-4.patch15.52 KBquietone
#3 2890311-3.patch14.44 KBquietone
#2 2890311-2.patch14.01 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2890311-2.patch14.01 KB

Here a go at making an ubercart sub module. The new module adds a phone field to the profile, and now include the migration and migration test. And a test of the source plugin has been added.

quietone’s picture

quietone commented
StatusFileSize
new 2890311-3.patch14.44 KB

Just fix the tests. OrderTest needed the new module installed.

quietone’s picture

quietone commented
StatusFileSize
new 2890311-4.patch15.52 KB
new interdiff.txt2.78 KB

Fix the test and a typo in test fixture.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman
Status: Needs review » Reviewed & tested by the community

Looks great. Patch didn't apply (probably because of #2888632: Add more assertions to all assert entity tests.) I'll apply later via PhpStorm which has some magic in it.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2890311-6.patch14.48 KB
new interdiff.txt2.15 KB

Reroll.

quietone’s picture

quietone commented
Status: Needs review » Needs work
quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2890311-8.patch15.61 KB
new interdiff.txt1019 bytes

Needed to delete the old test.

  • mglaman committed fdd3114 on 8.x-2.x authored by quietone 
    Issue #2890311 by quietone: Add phone number field for billing profile...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.