Problem/Motivation

The current assert entity tests tests only a few things about the entity.

Proposed resolution

Assert more stuff! Add assertions to test what is currently migrated or is set to some default. Also, add tests for all products/orders etc in the Ubercart 6 migration.

Remaining tasks

Do it.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#5 2888632-5.patch14.04 KBquietone
#2 2888632-2.patch14.48 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2888632-2.patch14.48 KB

Something like this. It still need work.

quietone’s picture

quietone commented
Parent issue: #2874667: Add a trait assertEntity functions for tests »

Status: Needs review » Needs work

The last submitted patch, 2: 2888632-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2888632-5.patch14.04 KB

That was a bad patch, ignore it.

  • mglaman committed 27546f8 on 8.x-2.x authored by quietone 
    Issue #2888632 by quietone: Add more assertions to all assert entity...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.