Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The patch adds 3ds
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff-5-9.txt | 11.61 KB | czigor |
#9 | commerce_authnet-2950906-3ds-9.patch | 27.48 KB | czigor |
Comments
Comment #2
czigor CreditAttribution: czigor at Centarro commentedIf we choose Carinal Cruise, here's a link with example implementation links:
https://github.com/AuthorizeNet/accept-sample-app/blob/master/README-Car...
Comment #3
czigor CreditAttribution: czigor at Centarro commentedPreliminary patch for backup purposes.
Comment #4
czigor CreditAttribution: czigor at Centarro commentedThe patch adds 3DS support for accept.js. It adds a composer dependency for JWT handling.
Comment #5
czigor CreditAttribution: czigor at Centarro commentedBetter error handling. Also rounding the cardinal order amount since they need an integer.
Comment #6
mglamanWe should use the commerce rounder
Is this the same jwt library API-first is using? I think the simple_oauth has a JWT library
Comment #7
czigor CreditAttribution: czigor at Centarro commented@mglaman The commerce Rounder still returns a float (e.g. "8.00") and we need a minor unit amount as integer (e.g. "8").
Yes, simple_auth is using the same lcobucci/jwt lib.
Comment #8
mglamanWhite space nits
Why would we reload versus showing an error, curious?
s/request/query?
s/request/query
We shouldn't use $_SESSION directly but the
session
service.Comment #9
czigor CreditAttribution: czigor at Centarro commented@mglaman
1-2: Fixed
3-4: We send the jwt in POST, not in GET, so it should be ok the way it is.
5. Using tempstore.private service instead of $_SESSION now.
Comment #10
mglamanThis looks awesome! Will merge later today :D
Comment #12
mglamanCommitted! Awesome!