Error when creating a new order from admin interface manually

Just wanted to add that I'm still having an error trying to create an order manually, the order itself creates now with above fix but I still can't add any products, as I get an AJAX error. Here is the debug info on that:

Error: Call to a member function getDefaultVariation() on null in web/modules/contrib/commerce/modules/product/src/Plugin/Field/FieldWidget/ProductVariationAttributesWidget.php on line 215 #0

Which is this function:

  public function massageFormValues(array $values, array $form, FormStateInterface $form_state) {
    /** @var \Drupal\commerce_product\Entity\ProductInterface $product */
    $product = $form_state->get('product');
    $default_variation = $product->getDefaultVariation();
    $variations = $this->variationStorage->loadEnabled($product);

    foreach ($values as &$value) {
      $attribute_values = isset($value['attributes']) ? $value['attributes'] : [];
      $selected_variation = $this->variationAttributeMapper->selectVariation($variations, $attribute_values);
      if ($selected_variation) {
        $value['variation'] = $selected_variation->id();
      }
      else {
        $value['variation'] = $default_variation->id();
      }
    }

    return parent::massageFormValues($values, $form, $form_state);
  }

I'm not exactly sure how to handle this one, as it returns to the parent function it is a child of, so I probably can't just do a return null if the product is null.

Any ideas?

@bojanz

The website is still in development, and I was asked to create a way for orders in commerce->orders to show up with a flag if they have not been viewed yet. In order to begin working on this, I went to add a new order manually through the admin UI (commerce->orders->create a new order), and that is when I experienced this crash. I do not believe that I have any custom code related to this in any way, my commerce module is otherwise stock, as I don't change anything at the contrib module level unless I absolutely have to, and even then I only do it temporarily.

I'm not sure why it is running, but I'm assuming that what is happening is I create a new order and it goes to load products.

However, this may be related to my own custom module, which emails the receipt of a new order to the sales user selected by the purchaser during registration, perhaps this is what is triggering this code to be run? It uses OrderCompleteSubscriber

<?php

namespace Drupal\sahara_wireless\EventSubscriber;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Drupal\state_machine\Event\WorkflowTransitionEvent;
use Drupal\commerce\MailHandlerInterface;
use Drupal\commerce_order\Entity\OrderInterface;
use Drupal\commerce_order\OrderTotalSummaryInterface;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\Core\StringTranslation\StringTranslationTrait;

/**
 * Class OrderCompleteSubscriber.
 *
 * @package Drupal\sahara_wireless
 */
class OrderCompleteSubscriber implements EventSubscriberInterface {

  /**
   * Drupal\Core\Entity\EntityTypeManager definition.
   *
   * @var \Drupal\Core\Entity\EntityTypeManager
   */
  protected $entityTypeManager;

  /**
   * The profile view builder.
   *
   * @var \Drupal\profile\ProfileViewBuilder
   */
  protected $profileViewBuilder;

  /**
   * The mail handler.
   *
   * @var \Drupal\commerce\MailHandlerInterface
   */
  protected $mailHandler;

  /**
   * The order total summary.
   *
   * @var \Drupal\commerce_order\OrderTotalSummaryInterface
   */
  protected $orderTotalSummary;

  /**
   * Constructor.
   */
  public function __construct(EntityTypeManagerInterface $entity_type_manager, MailHandlerInterface $mail_handler, OrderTotalSummaryInterface $order_total_summary) {
    $this->entityTypeManager = $entity_type_manager;
    $this->mailHandler = $mail_handler;
    $this->orderTotalSummary = $order_total_summary;
    $this->profileViewBuilder = $entity_type_manager->getViewBuilder('profile');
  }

  /**
   * {@inheritdoc}
   */
  static function getSubscribedEvents() {
    $events['commerce_order.place.post_transition'] = ['orderCompleteHandler'];

    return $events;
  }

  /**
   * This method is called whenever the commerce_order.place.post_transition event is
   * dispatched.
   *
   * @param WorkflowTransitionEvent $event
   */
  public function orderCompleteHandler(WorkflowTransitionEvent $event) {
    /** @var \Drupal\commerce_order\Entity\OrderInterface $order */
    $order = $event->getEntity();
    $items = $order->getItems();

    if ($order) {
      $customer = $order->getCustomer();
      if (!$customer->isAnonymous()) {
        $list = \Drupal::entityTypeManager()
          ->getStorage('profile')
          ->loadByProperties([
            'uid' => $customer->id(),
            'type' => 'wholesaler',
          ]);
        $profile = current($list);
        if ($profile) {
          if ($profile->hasField('field_sales_associate')) {
            $salesAss = $profile->get('field_sales_associate')->first()->getValue();
            $salesAcc = \Drupal\user\Entity\User::load($salesAss['target_id']);
            if ($salesAcc) {
              $salesEmail = $salesAcc->getEmail();
              if ($salesEmail) {
                $mailManager = \Drupal::service('plugin.manager.mail');
                $module = '***********';
                $key = 'wholesale_order_new';


                $to = $salesEmail;
                if (!$to) {
                  return false;
                }

                $bcc = "*******************";

                $subject = 'New Wholesale Order #' . $order->getOrderNumber() . ' Completed';
                $body = [
                  '#theme' => 'commerce_order_receipt',
                  '#order_entity' => $order,
                  '#totals' => $this->orderTotalSummary->buildTotals($order),
                ];

                if ($billing_profile = $order->getBillingProfile()) {
                  $body['#billing_information'] = $this->profileViewBuilder->view($billing_profile);
                }

                $params = [
                  'id' => 'order_receipt',
                  'from' => $order->getStore()->getEmail(),
                  'bcc' => $bcc,
                  'order' => $order,
                ];

                return $this->mailHandler->sendMail($to, $subject, $body, $params);
              }
            }
          }
        }
      }

    }
  }

}

Perhaps this is what is responsible?

Edit:

Actually looking over it, this is probably exactly what is responsible, probably $order->getItems() that's kicking all of this off. I will deal with it, thanks.

@bojanz

Oh yeah, got it working, it was because of the order item purchased entity form display mode was set to "product variation attributes", ended up googling around even more and found a post on IIRC stack overflow describing a similar issue and fix, and once I changed it to autocomplete I had no more issues. Hopefully this helps anyone else who comes across it.