Remove t() from test assertions [#1380620]

It seems that not having t() in assertions is a convention as for #500866: [META] remove t() from assert message.

We could remove it from all these assertions #500866-42: [META] remove t() from assert message.

But let's be careful #500866-96: [META] remove t() from assert message with it :)

Submitting this as "feature request" because we may don't need it right now.

Comment	File	Size	Author
#5	remove-t-1380620-4.patch	182.75 KB	msti
#5	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 168 pass
#2	remove-t-1380620-2.patch	183.43 KB	joshmiller
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rszrama CreditAttribution: rszrama commented 14 November 2012 at 06:39

Category:	feature	» task
Issue tags:		+low-hanging fruit

Tagging.

Comment #2

joshmiller

he/him

English

Indianapolis, Indiana, USA

CreditAttribution: joshmiller commented 21 April 2013 at 19:43

File	Size
remove-t-1380620-2.patch	183.43 KB

Used the following to create this patch:

perl -pi -e "s|\\\$this->assert(.*), t\\((['\"])(.*)(['\"])\\)\\);|\\\$this->assert\\1, \\2\\3\\4);|" $(egrep -rl '\$this->assert.*, t\(.*\)\);' modules)
git diff --no-prefix >~/Desktop/test.patch

It actually looks good to me... it leaves the t() functions alone that have text replacements. I think replacing the t()'s that also santize is what derailed the core conversation.

Take a look, comments welcome.