Coding Standards Meeting Wednesday 2025-01-28 2100 UTC [#3490058]

Hello all, it’s time for the fortnightly coding standards meeting.

This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.

Current ping list: @catch, @larowlan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch

0️⃣ Welcome back after the end of year holiday period!

1️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

larowlan	Hi
dww	Hi
borisson_	:wave:

2️⃣ What topics do you want to discuss? Post in this thread and we’ll open threads for them as appropriate.

3️⃣ Action Items

3️⃣.1️⃣ Approve minutes for previous meeting(s)

quietone	There are 2 at NR
quietone	https://www.drupal.org/project/coding_standards/issues/3482661
quietone	https://www.drupal.org/project/coding_standards/issues/3485765

3️⃣.2️⃣ TBA

4️⃣ RTBC issue,#3422530: Require short ternary (Elvis operator) syntax

quietone	This looks ready for doc updates and unpostoning the coder issue.
quietone	Is that right?
borisson_	It is. I marked the coder issue as active

4️⃣.1️⃣ Merging doc pages,#3492835: Merge 'Object-oriented code' page into 'PHP coding standards' page (edited)

quietone	This was simple merging two pages into one.
quietone	Then @drunken monkey reviewed the change but was confused by a bit, which I then broken into headings. This is the part that needs to be checked.

4️⃣.2️⃣ Comment style for enum.#3490054: Comment style for Enum

quietone	Since enum is a recent edition, can we make progress on the format of comments? And also decide if they comments are optional or required.
quietone	The issue proposed inline comment but the idea of using the doc block style has been proposed.
quietone	What do you think?
dww	I commented (again) at the issue with my thoughts on the current proposals.

4️⃣.3️⃣ Committee membership change,#3501601: Remove larowlan from coding standards committee

quietone	Thanks for all the help in getting the committee up and running. I will miss you here!
quietone	On the admin side, I think the only task here is to update the project page.
smustgrave	Thank you for all you’ve down larowlan!
smustgrave	Question @quietone does this mean need a replacement or the people that are there enough?
quietone	That could be. The committee does not have a recommended number of members or any other limitation. Nor do we have a process for inviting or calling for new members.
smustgrave	If I wanted to recommend someone do I ask them to open a ticket
quietone	However, there was an intention to follow the renewable terms for committers once that was committed. And since the one for subsystem and topic maintainers has been committed, I think we should use that.
quietone	That makes sense. They could also ask for private chat with a current member, if they want to.
borisson_	If I wanted to recommend someone do I ask them to open a ticketI think as a first step they can participate in these meetings, as well as comment on some of the issues in the queue. Supporting changes to the standards is a thing they can do as well.

4️⃣.4️⃣ Require backslash prefix for global functions[#3259666]

quietone	This is at step 3, needing a change record.
quietone	After that is to review here. How about we use this meeting as the review? The issue has supporters from the CS committee and there are no comments on the issue disagreeing with this proposal.
yesct	I could write a change record.
quietone	@yesct, thanks!
borisson_	https://www.drupal.org/project/coding_standards/issues/3501643 was opened as a related issue, but it doesn't have the required number of supporters yet. Is this something we'd want to tackle at the same time?
borisson_	Does that make the language in the docs easier, to do it at once? I don't think so, but I wanted to ask the question anyway
quietone	Yea, they are different and I agree with you splitting 3501643 out,
yesct	My aim is to write a CR today. But if I don't please don't wait on me.
yesct	Have time, but now have headache. I'll check back in tomorrow.

4️⃣.5️⃣ Allow usage of stdclass instead of object where it makes sense. Coder is changed but not Core standards,#3315957: Allow stdClass instead of object in tags that include a data type

quietone	Coder has been changed to allow this which puts Coder out of sync with the documented standards.
quietone	What is your opinion of the change?
dww	Seems like a good fix. Appears that coder used to be replacing this when it shouldn't, and now it doesn't do the thing it shouldn't do. ;) I'm not clear there's a documented standard anywhere being updated, right? This seems more like a bug in coder, not a task for the CS committee.
quietone	The doc change, which isn't in the issue summary, would be because stdclass is not a PHP data type .
quietone	I think it this part, https://www.drupal.org/docs/develop/standards/php/api-documentation-and-...
dww	Oh, yeah, I see:object (NOT "stdClass")

4️⃣.5️⃣ Define order of object method modifiers as in PSR-12[#2855980]

quietone	Unless I am mistaken this is updating docs to what is already done and enforced.
quietone	If that is true, then shall we skip the change record? (edited)
quietone	If the CR is not required then, do we agree to the doc update?
dww	Seems uncontroversial to me. Lots of +1 over the years (!) this has been open. We'd be formally document existing practice and standards. I say we move forward, and don't bother with the CR.
dww	The new docs look okay to me.