Hello all, it’s time for the fortnightly coding standards meeting.

This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.

Current ping list: @catch, @larowlan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

urvashi_vora Hello, hope everyone's is doing good :wave:
yesct Hey, I'm just dropping by to read the meeting messages and get a sense for what's going on currently.
larowlan Hey

1️⃣ What topics do you want to discuss? Post in this thread and we’ll open threads for them as appropriate.

2️⃣ Action items

2️⃣.1️⃣ Approve minutes for previous meeting(s)

quietone https://www.drupal.org/project/coding_standards/issues/3479501
urvashi_vora Reviewed and Fixed.

2️⃣.2️⃣ TBD

3️⃣ RTBC issues (edited) 

3️⃣.1️⃣ Elvis operator[#3422530]

quietone I think we need a coder issue?
mstrelan Can we un-postpone[#3422531]?
quietone Oh, there is an existing rule and a core MR. Nice.
quietone I think we can un-postpone when we get to Step 9 in the process.

3️⃣.2️⃣ Enum,#3339746: Coding style for PHP Enumerations

quietone This needs some testing to determine sniff parameters to get the spacing correct.
quietone Who would like to do that testing?

4️⃣ Other

4️⃣.1️⃣ Use statement sort[#1624564]

quietone Unfortunately, this is causing problems.
quietone In comment #98 klausi makes a nice short summary and a suggestion and catch also makes a suggestion in #95,
mstrelan How come it was implemented in coder before the standard was finalised?
quietone I lean to catch's idea of adopting the change but not implementing. That way we keep the hope of having a known order.
quietone Even if is was implemented after all the steps here, what was missed is thorough testing.  For example, we didn't catch that PHPStorm automatically adds use statements in a different order than the 'sort lines' actions.
quietone I guess then than Coder should revert the change. Those projects that have updated will likely just have to do some reverts.
Jonathan1055 Can we clarify something - when we talk about reverting the rule, do we mean the entire sniff? or just the last addition when case-sensitivity was added?
kimb0 Yeah, I think a revert is the best option until we agree on the standard.
kimb0 Switching to case-insensitive ordering for example would just affect other ide's according to the issue.
Jonathan1055 I prefer a full revert too, so we remove the sniff entirely. Then we could even work towards a human-useful standard like @krystalcode suggested in comment 103, to allow for blocks of use statements with a blank line and comment between. We do not need to rely on the sniff provided by slevomat, Coder can have a customised one.
yesct If the group approach reduces to the simple case of one group, then I think that approach could work. (Could allow a max of "a super big number".)
yesct Personally, I want an order, any order is better than no order.
catch I think someone should open an issue against coder to revert. We don't have any special status as far as what coder implements, I think it is mostly people trying to get ahead of/ready for upcoming coding style changes, but as we see in this case it can go wrong.
catch Drupal core doesn't use the standard code ruleset, so when coder makes changes like this, core doesn't notice - otherwise HEAD would be broken forever.
quietone @Jonathan1055 When I said revert I meant to revert the changes to the Code project, which needs an issue in Coder.
quietone @Jonathan1055 I would like to keep a coding standard rule so the order is deterministic. Then projects can decide to follow it or not.
quietone Here is the Code issue to revert,#3483028: Remove use-statement order sniff
Jonathan1055 Yes I did not mean we don't want a standard for use statements, just that as is it not decided yet what that will be, I think it would be better to remove the entire Coder rule, not just the latest change which added case-sensitivity. Then when the standard is agreed, we can write the sniffs that implement exactly what we want. If we leave in place the sniff which does a plain sort, we'll be creating phpcs failures again for those projects which have just committed changes to satisfy case-sensitivity. We will create more annoyance than good, until the standard is fully settled, so best to remove the Coder rule entirely.

4️⃣.2️⃣ Committee tasks/job description

quietone One thing I like about a job description is that is useful when encouraging people to join a team. And yes, for many of us, this is probably not as fun as working on an issue. But overall, having knowing what the job entails helps us all.
quietone It would be great to have some feedback, https://docs.google.com/document/d/1612Bx_qBQJaqkkNeAvoeHZjBg3QBKybq8aXA...
quietone I was thinking it could be added as documentation for the project. (edited)
urvashi_vora The document looks great. There definitely is a space for improvement. Seems I don't have access to edit it to help make it better.
larowlan expanded on one section using a suggestion
quietone @urvashi_voraYou should have access. Can you make a request for access or send me you email address to use?
quietone I did set up the access incorrectly for the community. That should be fixed no.
quietone https://docs.google.com/document/d/1612Bx_qBQJaqkkNeAvoeHZjBg3QBKybq8aXA...

Comments

quietone created an issue. See original summary.

quietone credited catch.

quietone credited jonathan1055.

quietone credited kim.pepper.

quietone credited larowlan.

quietone credited mstrelan.

quietone credited urvashi_vora.

quietone credited yesct.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review
quietone’s picture

quietone commented
a.aaronjake’s picture

a.aaronjake commented

Will there be another meeting? I'd like to join and learn from you guys! Also I'd like to kindly ask some instructions on how to join. :peace:

Thanks,
Jake

quietone’s picture

quietone commented

@a.aaronjake, Welcome! The issue summary explains when meetings are held and where we meet. Discussion can happen at any time in the #coding_standards Drupal Slack channel. Hope to see you there.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.