Problem/Motivation
In #3412641: OpenTelemetryNodePagePerformanceTest::testNodePageHotCache() is not hot enough @catch found a problem with / being in the drupalGet() call. So sparked the idea about maybe we should standardize this to be
Benefits
If we adopted this change, the Drupal Project would benefit by ...
Cleaner code and in the case of the issue related fix performance testing
Three supporters required
- https://www.drupal.org/u/smustgrave 4/11/2024
- https://www.drupal.org/u/{userid} (yyyy-mm-dd they added support)
- https://www.drupal.org/u/{userid} (yyyy-mm-dd they added support)
Proposed changes
Provide all proposed changes to the Drupal Coding standards. Give a link to each section that will be changed, and show the current text and proposed text as in the following layout:
Since removing the slash in the issue fixed it and the tests were around performance I'm in favor of not neededing.
1. {link to the documentation heading that is to change}
Current text
Add current text in blockquotes
Proposed text
Add proposed text in blockquotes
2. Repeat the above for each page or sub-page that needs to be changed.
Remaining tasks
Create this issue in the Coding Standards queue, using the defined template- Add supporters
- Create a Change Record
- Review by the Coding Standards Committee
- Coding Standards Committee takes action as required
- Discussed by the Core Committer Committee, if it impacts Drupal Core
- Final review by Coding Standards Committee
- Documentation updates
- Edit all pages
- Publish change record
- Remove 'Needs documentation edits' tag
- If applicable, create follow-up issues for PHPCS rules/sniffs changes
For a full explanation of these steps see the Coding Standards project page
Comments
Comment #2
larowlanI think this belongs in the core queue. Once a decision is made we can deprecate the 'wrong' way and trigger an error
Comment #3
alexpottIf we make the change suggested in #3412641-11: OpenTelemetryNodePagePerformanceTest::testNodePageHotCache() is not hot enough I don;t think we need to do this.
Comment #4
alexpottI think we should close this in favour of #3440424: Inconsistent behaviour with drupalGet() when site is installed in a subdirectory - I don't think this type of things should be a coding standard.
Comment #5
larowlanAgree, excellent find in that one