Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Standing items

  • Who is here?
  • What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
  • Action Items
  • Approve previous minutes
  • Wrap up

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

borisson_ :wave: Joris, Mechelen
Arkener :wave: Mitch @ INDICIA, Tilburg. Co-maintainer of the Coder project.

0️⃣.5️⃣ What insects do you like?

quietone Cicadas, weta and the lady bug.

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

quietone How to announce an issue for final discussion?
quietone #2790151: Should inline comment always end with the period?
quietone Reminder to help keep the issues in 'Review for beta' at RTBC.

2️⃣ Action items

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!

quietone We closed an issue, #2469299: Clarify function declarations sentence in coding standards

2️⃣.2️⃣ Approve last fortnight's minutes

3️⃣ How to announce an issue for final discussion?

quietone The Process for Changing Coding Standards  states "The announcement will be made via TWG Twitter account, groups.drupal.org/governance, groups.drupal.org/core, and "this week in drupal core""
quietone Should we continue that process?
quietone if we do, we'll have to learn how to add something to http://groups.drupal.org/core
quietone For reference, here are links to previous announcements, https://groups.drupal.org/node/510675 and https://groups.drupal.org/node/509885
borisson_ I think that is a good idea, it will hopefully get people involved. There are 5 issues that are tagged and can be moved to the next step: https://www.drupal.org/project/issues/search?issue_tags=Needs%20announce...
borisson_ Luckily @Björn Brala (bbrala) is already a group maintainer for the group, so we don't have to find how to be added to the list :slightly_smiling_face:
borisson_ I think that intro text can just be reused? That + those 5 issues should be enough in the announcement?

The TWG coding standards committee is announcing two coding standards changes for final discussion. These appear to have reached a point close enough to consensus for final completion. The new process for proposing and ratifying changes is documented on the coding standards project page.
The x issues being proposed are:

Björn Brala (bbrala) Currently on vacation so a little distracted :sweat_smile: will set a reminder (nr 15) for when I'm back
Björn Brala (bbrala) My permissions on that group are a little weird. I'd need to ask to het permissions fixed to create posts. I have the proper roles but cannot post new posts. This was an issue last year and a placeholder under my name was created to keep moving but I never went through and got it properly fixed.

Also if its about pages/guides I think those are assigned to specific people, so the blanket being added to the core group is not enough.

It seems @Gábor Hojtsy (he/him) has quite the permissions for that group so he might be able to help fix?

Gábor Hojtsy (he/him) "This week in Drupal core" is long done now.
Björn Brala (bbrala) It seems those channels are not really active yeah.
Björn Brala (bbrala) If that is no longer viable, then the question becomes, what should the process be. I mean there needs ti be some sort of announcement somewhere. A post on the blog could be a way to do it. But we'd kinda need to change the process on the main page of the codingsyandards project.

This means we'd probably need to add some maintainers to that project that are active here. Therefor u guess we need to create an issue requesting to be added as maintainers for that project.

Also, the coding standards guide (is a guide id guess?) Would need to add the same ppl.

@quietone I guess those are possible next steps to enable some sort of renewed management of the project?

Björn Brala (bbrala) And thanks @Gábor Hojtsy (he/him) for pitching in :)
Gábor Hojtsy (he/him) I think @effulgentsia is the last remaining TWG member?
Gábor Hojtsy (he/him) (not sure if he ever shows up on slack though)

4️⃣ #2790151: Should inline comment always end with the period?

quietone This looks like it can be closed as works as designed.
borisson_ I agree
Arkener Seems clear to me
borisson_ closed

5️⃣ Reminder to help keep the issues in 'Review for beta' at RTBC.

quietone The list is at the top of the channel in a book mark folder. (edited)

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone credited Arkener.

quietone credited bbrala.

quietone’s picture

Issue summary: View changes
Status: Active » Needs review
quietone’s picture

Status: Needs review » Fixed

There were no requests for changes at the following meeting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

Project: Drupal core » Coding Standards
Version: 9.5.x-dev »
Component: meetings » Meeting

This should be in the Coding Standards project.