Handle hook_theme() elements with no arguments [#765070]

Running coder_upgrade against amazon_store (D6 dev) I got these messages. They're completely unformatted and hard to follow. The upgrade seemed to work.

ERROR: Undefined index: arguments on line 128 in /home/rfay/workspace/d7git/sites/all/modules/coder/coder_upgrade/conversions/coder_upgrade.begin.inc ERROR: Undefined index: arguments on line 128 in /home/rfay/workspace/d7git/sites/all/modules/coder/coder_upgrade/conversions/coder_upgrade.begin.inc ERROR: preg_match(): Compilation failed: nothing to repeat at offset 0 on line 50 in /home/rfay/workspace/d7git/sites/all/modules/coder/coder_upgrade/conversions/coder_upgrade.install.inc

Comments

Comment #1

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 8 April 2010 at 00:16

Title:

Many error messages when running coder_upgrade.

» Handle hook_theme() elements with no arguments

Talking with solotandem in IRC, he suggested adding bogus arguments to the two hook_theme() elements that didn't have arguments. I did, and that took care of a couple of the items above.

Remaining after that is:

Warning: Unexpected character in input: ' in /home/rfay/workspace/d7git/sites/all/modules/grammar_parser/engine/grammar_parser.reader.inc on line 3001 ERROR: preg_match(): Compilation failed: nothing to repeat at offset 0 on line 50 in /home/rfay/workspace/d7git/sites/all/modules/coder/coder_upgrade/conversions/coder_upgrade.install.inc

Comment #2

rfay

English

Palisade, CO, USA

CreditAttribution: rfay commented 8 April 2010 at 00:18

It is not unusual to have theme elements that take no arguments. So for example, calls to theme('status_messages') are currently being annotated by by coder_upgrade to add an array() arg, but it doesn't take one. So making this friendlier in hook_theme and elsewhere will be good.

Comment #3

solotandem CreditAttribution: solotandem commented 8 April 2010 at 14:53

Assigned:	Unassigned	» solotandem
Status:	Active	» Fixed

Fixed in next dev release.

Error message 1:
The 'status_messages' theme seems not to be the best example as the documentation lists a parameter and the theme_status_messages($variables) function expects the parameter with a key of 'display'. Nonetheless, the routine was changed to check for any 'variables' in the theme registry entry before adding the comment.

Error message 2:
Invalid regex to have a '*' leading the charge. Need to escape it as '\*'.

Also improved the routine that converts the hook_block() so that it now upgrades the hook_block in amazon_store module.

Thanks for using the module and posting the issue.