I've done a code review with coder and ran it with the following checked:

Converting 5.x modules to 6.x
Drupal Coding Standards (every developer should use)
Drupal Commenting Standards (every developer should use)
Drupal SQL Standards (new review, so use with caution)
Drupal Security Checks (very basic, needs work, but what it finds is good)
Interface text translatability
Internationalization
minor (most)
include files (inc | php | install | test)

I get over 100 complains about bugs in the code that are not bugs. Could you please run coder on linkchecker and take a look, please? None of the lines coder complains about is wrong...

Comments

hass’s picture

hass commented

I've also tried 6.x-1.x-dev. Same picture.

stella’s picture

stella commented
Status: Active » Postponed (maintainer needs more info)

Is this still a problem? If it is I'll take a look. In the meantime, this will have to wait until higher priority tickets are dealt with.

hass’s picture

hass commented
Status: Postponed (maintainer needs more info) » Active

Yes, there are still issues. Most issues are with po files.

hass’s picture

hass commented
Title: Only invalid errors reported on linkchecker 2.3 » Only invalid errors reported on linkchecker 2.x
hass’s picture

hass commented

Have you been able to review the bugs?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
Status: Active » Closed (won't fix)

Coder for Drupal 6 is now frozen and only security fixes will be applied. Feel free to update this issue and reopen against 7.x-2.x or 8.x-2.x.

hass’s picture

hass commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Closed (won't fix) » Active
pfrenssen’s picture

pfrenssen
Location Sofia
commented

Does this linkchecker still exist? I grepped the codebase for 'link' but couldn't find anything relevant.

hass’s picture

hass commented

https://www.drupal.org/project/linkchecker

pfrenssen’s picture

pfrenssen
Location Sofia
commented

Oh I was mistaken, I thought this was about a legacy link checking feature in an old version of Coder, my apologies.

hass’s picture

hass commented

If you run a website with internal or external links you should have linkchecker module installed so nothing breaks without getting noticed :-)))

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Closed (won't fix)

Coder review in 7.x-2.x is now kinda frozen. Please try again with Coder 8.x-2.x and report individual false positives in new issues with code snippet to reproduce.

hass’s picture

hass commented
Status: Closed (won't fix) » Active

Yeah, try it and only close if the bugs are fixed. I was not yet able to get this working under windows since it is no longer a drupal module.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Closed (won't fix)

yes, please report individual false positives in new issues with code snippet to reproduce.