This task works toward a D9 release building off the automated upgrade patch in this issue. The attached patch has not been thoroughly tested, but adds support for D9 in info.yml files to the automated changes.

CommentFileSizeAuthor
#8 drupal_9_compatability-8.patch10.48 KBdamondt
#5 Implement_updated_compatability_3168749.patch2.73 KBPooja Ganjage
#4 drupal_9_compatability-4.patch10.48 KBdamondt
#3 drupal_9_compatability-3.patch9.49 KBdamondt
drupal_9_compatability-1.patch8.76 KBdamondt

Issue fork cloudinary-3168749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damondt created an issue. See original summary.

damondt’s picture

damondt commented

There is a nested dev dependency incompatible with Drupal 9 of doctrine/annotations: ^1.2 which is required by friendsofphp/php-cs-fixer which is required by cloudinary/cloudinary_php ^1.8 this could be solved by requiring 1.8.0 specifically.

damondt’s picture

damondt commented
StatusFileSize
new drupal_9_compatability-3.patch9.49 KB

Updated patch to resolve dependency conflict with D9.

damondt’s picture

damondt commented
StatusFileSize
new drupal_9_compatability-4.patch10.48 KB

Updated patch to resolve "The URI '' is invalid" message on image upload due to empty uri.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_updated_compatability_3168749.patch2.73 KB

Hi,

I am applying updated patch for #4 comment, that need to use dependency injection for drupal 9 compatability purpose.

Kindly review this patch once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
damondt’s picture

damondt commented
Status: Needs review » Active

Thanks for the dependency injection work, it will need to be rolled into patch #4 as patch #5 does not contain any of the other updates.

damondt’s picture

damondt commented
StatusFileSize
new drupal_9_compatability-8.patch10.48 KB

Added dependency injection fix from #5 and fix for accessing images.

damondt’s picture

damondt commented
Status: Active » Needs review

markdorison made their first commit to this issue’s fork.

markdorison opened merge request !1

markdorison’s picture

markdorison
he/him
commented

Created a fork/MR for the patch in #8 so it could be pulled in that way via Composer.

BioALIEN’s picture

BioALIEN commented

The cloudinary_php version 1.8.0 does not support PHP 7.4 so I am against hardcoding this in composer.json and PHP 7.3 will reach EOL in December 2021 so I recommend using the latest 1.20.0 branch of the library or at the minimum 1.18.0 which is where PHP 7.4 issues were resolved.

Christian.wiedemann made their first commit to this issue’s fork.

bunty badgujar’s picture

bunty badgujar commented
Priority: Normal » Critical

Hi all, I am trying to upgrade my project to Drupal 9 which using cloudinary but as this module doesn't have any release compatible to D9. We are not able to move core from D8 to D9. Moving this issue to critical.

intrafusion’s picture

intrafusion
Primary language English
Location Edinburgh, UK
commented
Priority: Critical » Normal

@Bunty Badgujar this is not a critical issue, please see https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... for details

There is a work around, you need to apply the patch from the merge request in this issue, see https://www.drupal.org/docs/develop/using-composer/using-composer-to-ins... how to do this

bunty badgujar’s picture

bunty badgujar commented

Thanks @intrafusion, for suggestion. As drupal package manager use info.yml file to check dependance, we can't even download this module in D9 composer based project. There is a work around that can use issue fork. use issue forks to make compatibility fixes work with composer

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Thanks for the link @Bunty Badgujar, here's the modifications I made to get it downloading myself:

1. Update composer.json:

    "repositories": {
        "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/cloudinary"
            ]
        },
        "cloudinary": {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/cloudinary-3168749.git"
        }
    },

2. composer require 'drupal/cloudinary:dev-3168749-drupal-9-compatability'

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented

I got an email from @abhinesh asking to become a maintainer to help on this issue. I advised him to help on this issue and we will merge this once reviewed by the community.

nginex’s picture

nginex commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs review » Fixed

Hey guys, new Drupal 9 release is now available, check it out!

You can simply install it with composer

composer require 'drupal/cloudinary:^2.0@alpha'

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.