Problem/Motivation

There are currently Functional tests for Image Upload Access and Image Upload,
We should evaluate whether there should be additional test coverage to match or exceed what CK4 has in core now.

Proposed resolution

Additional tests to cover image upload.

Comments

zrpnr created an issue. See original summary.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
CreditAttribution: zrpnr at Acquia commented
Issue tags: +d10readiness, +NorthAmerica2021

Tagging for Contribution event

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Issue tags: -d10readiness +Drupal 10

Fixing tags.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

AFAICT CKEditor 4 does not have tests for this — \Drupal\Tests\ckeditor\FunctionalJavascript\CKEditorIntegrationTest::testDrupalImageDialog() is the closest we have.

I don't think we had figured out how to upload files via drag-and-drop yet in functional JS tests back then… 🧙‍♂️

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Add test coverage for image upload » Add FunctionalJavascript test coverage for image upload
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Active » Closed (outdated)

Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Test::testEditorFileReferenceIntegration provides integration testing for the image upload. I think we could close this one.