Ok, now that I got past the errors on creating fields I have been able to try them out in a form. I created a short text and a long text field, and a couple other fields. I set up the short text fields to be one row. When I go to add info to the form, both short and long text fields show up as textarea fields instead. The title field (which I wasn't able to configure) is the only field that is showing up as a regular textfield.

When I look at the source html, the fields that should be 1 line short text fields are coded as textareas with 60 columns and 1 row. The fields I set up as long text show up as textarea fields with 60 columns and a blank value for rows (rows="").

Thanks for your quick responses!

Comments

karens’s picture

karens commented
Priority: Critical » Normal

This probably is not really a critical bug.

I found at least part of the solution:

Some fields with a value of "1" in rows are still getting treated as textareas. The fix for this is in text.module lines 234 and 238 (or thereabouts) where the following changes need to be made:

if ($field['rows'] == 1)

needs to be changed to

if ($field['widget']['rows'] == 1)

I also noticed that some fields are show a blank value for rows and they are automatically getting treated as textareas too. I think that is a change that needs to be made in the form where fields are set up to force a default value of 1 if no other value is chosen.

I also noticed in content.module around lines 734 and 739 that a default value is being fed to the checkboxes. The new forms API has changed this and you are supposed to set a return_value instead of default_value for a checkbox to keep it from return a bad value if the checkbox is not checked (found that out myself through trial and error on something else I was working on.)

jonbob’s picture

jonbob commented

The supplied correction has been applied. Thanks.

jonbob’s picture

jonbob commented
Status: Active » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)