As part of the upgrade of this module to work with Bootstrap 4, the current files need to be checked to ensure they still make sense and work correctly.

This issue is to deal with the file /screenshot.png only. It should be made from the background and font of the official Bootstrap website.

The expected contribution for this issue is either:

a. discussion,
b. a new file,
c. testing and confirmation of the file.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

waverate created an issue. See original summary.

waverate’s picture

Parent issue: » #2554199: Bootstrap 4
ressa’s picture

Issue tags: -
FileSize
20.95 KB
64.01 KB
41.99 KB
85.08 KB

I first tried putting the text on the right side, but having the text below the logo seem to work better. What do you think?

markhalliwell’s picture

Status: Active » Needs work

I'd get rid of the version. Something that could, theoretically, work for both 3 and 4 (and 5+, etc.). This will make it less of a big deal to update in the future.

I'm also semi-partial to using "Drupal Bootstrap" as that is typically how this project is referred to in documentation.

ressa’s picture

Status: Needs work » Needs review
FileSize
8.31 KB
41.55 KB

Thanks for the feedback @markcarver. Here is an updated version. I added the svg file as well (renamed to 2.1-logo.svg_.txt to allow uploading) for easier revising of the next version, should it be necessary.

Bootstrap screenshot

I just learned that the recommended screenshot dimensions are actually 588 pixels wide and 438 pixels high in https://www.drupal.org/node/2349827#screenshot

markhalliwell’s picture

Status: Needs review » Needs work

I still think it should say "Drupal Bootstrap" below.

It'd be nice to maybe put an outline of the duplicon around the B on the stack as well.

There should be some distinction so it doesn't look like a straight-up copy from Bootstrap.

ressa’s picture

All right. Changing the text is fairly simple. Your wish for an outline I'll leave for someone else to do.

Just a comment: An appreciative tone ("thanks", "looks good"), even if you don't mean it, makes all the difference in open source projects. Spending your free time on a project, and only getting critique back doesn't really motivate further work on a project.

markhalliwell’s picture

I do appreciate that you've taken this issue on. Thank you :D

I'm sorry that I didn't say that before.

I've been extremely busy and, as you mentioned, this is FOSS. I often barely get enough time to provide feedback and, in my eyes, providing feedback in a timely manner is what's most important so people don't waste their time.

My terseness and direct response are often misinterpreted and taken personally. That is never my intent. I tend to simply focus on the issue at hand.

I will attempt to do better and preface my remarks with the appreciation all of us volunteers deserve :D

ressa’s picture

Thank you for a fast response, and also just for working on Bootstrap. It is an amazing project that you are managing, and my go-to solution for sub-theming, which allows me to go from 0 to 100 really fast.

I do understand that you have a lot going on in the Bootstrap issue queue, and probably also working on projects for clients. Just getting the feedback out as fast as possible is important in itself, and something FOSS projects sometimes lack. But you manage to do that, and keep the issue queue alive, which is really awesome. And I don't mean that you should overdo the thanking, merely sprinkling the occasional "thanks" or "looking better" would probably be enough :)

ressa’s picture

Here are three suggestions, based on the feedback.

#1:

#2:

#3:

ressa’s picture

Status: Needs work » Needs review
markhalliwell’s picture

Wow, I really like #1!

I'm certainly no artist, but let me see if I can do what I was imagining in #6.

markhalliwell’s picture

Ok, here's what I was originally thinking...

Not sure if I like it now though. Still like #10.1 a little better.

I'm also attaching the PSD file I used.

ressa’s picture

FileSize
47.89 KB
11.94 KB

I like your vision of perspective! I have recreated it in Inkscape, so that it is vector-based, and learned a bit about Perspective Transforms in the process. I also attach my svg-file, with the different layers, but with .txt extension, since svg files are blocked.

I agree, the simplicity of #10.1 is not bad.

Here is #14.1:
Bootstrap screenshot

waverate’s picture

+1 for 14.1

Thank you @ressa.

markhalliwell’s picture

Status: Needs review » Reviewed & tested by the community

I really like #14 as well. It's a little cleaner looking.

I'm wondering if/should we translate some of this to
#3070116: File: favicon.ico and logo.svg

ressa’s picture

saxmeister’s picture

A major upvote for #14. Nice work!

markhalliwell’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.