Problem/Motivation

Needs to support other dialog types, e.g. drupal_popoverx (https://www.drupal.org/project/popoverx)

Proposed resolution

Abstract the Modal code even further to allow Drupal dialog type handlers to be registered.

This will need to be forward ported to 8.x-4.x.

CommentFileSizeAuthor
#3 3061758-3.patch28.52 KBmarkhalliwell
#3 interdiff-3061758-2-3.txt1.19 KBmarkhalliwell
#2 3061758-2.patch28.38 KBmarkhalliwell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markcarver created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Needs review
FileSize
3061758-2.patch28.38 KB
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff-3061758-2-3.txt1.19 KB
3061758-3.patch28.52 KB

  • markcarver committed 9f7fc57 on 8.x-3.x 
    Issue #3061758 by markcarver: Allow custom Drupal dialog type handlers...

  • markcarver committed fe93431 on 8.x-4.x 
    Issue #3061758 by markcarver: Allow custom Drupal dialog type handlers...
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.