D7 Port

Hi,

Thanks! The functionality seems to be there. There's just three problems I encountered:

1. There is no specific settings in content types that would override the global setting, as the help would suggest (Structure -> Content Types -> Edit shows "BookMadeSimple" at the bottom, but it's not expandable.)

It doesn't seem like there are any global settings that would need overriding, though.

2. When automatically creating a new book using the content type, the following errors appear:

Notice: Undefined index: depth in book_made_simple_node_insert() (line 495 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).

3. When viewing any pages in the new book (parent or child), the following errors appear:

Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).

Finally, all the functionalities seem to be there (on the surface, at least), and I love the "reorder book" link! Having it inside /admin and needing to adjust administration theme is not pleasant, but I guess there's really nothing to do about it.

Thanks for the quick response and please feel free to ask me for more help. I'm not really familiar with drupal development or I would have been much more proactive in patches - sorry...

Hi,

Thanks! The functionality seems to be there. There's just three problems I encountered:

1. There is no specific settings in content types that would override the global setting, as the help would suggest (Structure -> Content Types -> Edit shows "BookMadeSimple" at the bottom, but it's not expandable.)

It doesn't seem like there are any global settings that would need overriding, though.

2. When automatically creating a new book using the content type, the following errors appear:

Notice: Undefined index: depth in book_made_simple_node_insert() (line 495 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).

3. When viewing any pages in the new book (parent or child), the following errors appear:

Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Trying to get property of non-object in book_made_simple_link() (line 407 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).

Finally, all the functionalities seem to be there (on the surface, at least), and I love the "reorder book" link! Having it inside /admin and needing to adjust administration theme is not pleasant, but I guess there's really nothing to do about it.

Thanks for the quick response and please feel free to ask me for more help. I'm not really familiar with drupal development or I would have been much more proactive in patches - sorry...

The warning messages seem to have disappeared on book pages, and the fieldset legend shows up now - all great!

But the configuration page /admin/config/book_made_simple now shows:

Fatal error: require_once(): Failed opening required '/public_html/sites/all/modules/book_made_simple/system.admin.inc' (include_path='.:/usr/lib/php:/usr/local/lib/php') in /public_html/includes/menu.inc on line 478

And /admin in general shows:

Warning: require_once(/public_html/sites/all/modules/book_made_simple/system.admin.inc): failed to open stream: No such file or directory in menu_execute_active_handler() (line 478 of /public_html/includes/menu.inc).

That's all.

Also, my remark last time was about the fact that the link "reorder the book" leads to /admin/content/book/59?destination=node/59, which is in /admin and uses the administration theme (something that can cause inconsistencies on the user side). I guess it'ld be too hard to change that one though.

Removing line 38 did get rid of all the error messages and allowed me to get into admin/config/book_made_simple.

One more problem, though: if in the configs we choose "unordered list" for style of child list, on book nodes, after the content, there is a giant error box that start off:

Error

The website encountered an unexpected error. Please try again later.

and says:

Error message

Recoverable fatal error: Argument 1 passed to drupal_http_build_query() must be an array, string given, called in /public_html/includes/common.inc on line 2134 and defined in drupal_http_build_query() (line 469 of /public_html/includes/common.inc).

The "unordered list" works now. Two problems, though:

1. Every content type that's not allowed to start a book displays the following error:

Notice: Undefined index: parent in book_made_simple_form_alter() (line 203 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Use of undefined constant value - assumed 'value' in book_made_simple_form_alter() (line 206 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).
Notice: Undefined index: #tree in form_builder() (line 1673 of /public_html/includes/form.inc).
Notice: Undefined index: process_input in _form_builder_handle_input_element() (line 1834 of /public_html/includes/form.inc).
Notice: Undefined index: #tree in form_builder() (line 1673 of /public_html/includes/form.inc).
Notice: Undefined index: process_input in drupal_process_form() (line 752 of /public_html/includes/form.inc).

2. Link to the config from the sidebar is /admin/config/book_made_simple, which doesn't work. /admin/config/book_made_simple/config does, but displays the following error:

Warning: call_user_func_array(): First argument is expected to be a valid callback, 'system_admin_menu_block_page' was given in menu_execute_active_handler() (line 480 of /public_html/includes/menu.inc).

1. The error messages disappeared, but there seems to be a communication problem:

Any content type not allowed to start a book gives the following message when clicked on under the "add content" menu:

This content-type cannot be created outside a book. Creation cancelled

I'm not sure if that's intentional or has to do with the way Drupal deals with nodes, but disallowing something to start a book doesn't imply disallowing the content to be created as a stand-alone node by itself. It was a little confusing until I figured it out.

2. Screenshot attached. I'm using the Bartik theme, and the link /admin/config/books_made_simple leads to a blank page. The error message that displays for /admin/config/books_made_simple/config, which does work, is also attached.

Yes the configure link in module admin page work. It's just the sidebar that's not expanding and leading to a blank page.

Other options do expand, though, and I see the same error in Garland theme.

Also, one more problem:

When anonymous users create nodes that are not related to the books_made_simple module (no options checked), the following error message displays in the "create content" page:

Notice: Undefined property: stdClass::$book in book_made_simple_form_alter() (line 224 of /public_html/sites/all/modules/book_made_simple/book_made_simple.module).

This is not the case for registered users - just anonymous ones.

As far as I can tell this works perfectly. Thank you!!